Repository navigation
fix: ensure CalOS branding wins in fastfetch and os-release - #50
Merged
Merged
Conversation
Fastfetch showed "Bluefin stable" and the base image's defaults because it reads /etc/os-release FIRST (falling back to /usr/lib/os-release), and the image relied on an unsupported FASTFETCH_CONFIG env var that fastfetch never reads. - build.sh: symlink /etc/os-release to the CalOS-branded /usr/lib/os-release - build.sh: drop dead FASTFETCH_CONFIG exports; document that fastfetch loads fastfetch/config.jsonc from ~/.config, $HOME, $XDG_CONFIG_DIRS, /etc/xdg, /etc, and rely on /etc/fastfetch/config.jsonc + skel + preset instead - docs/BRANDING_SYSTEM.md: describe the actual fastfetch config mechanism - docs, README, workflow comments: bump release examples to v1.1.5 Co-Authored-By: Codebuff <noreply@codebuff.com>
github-actions
Bot
added
documentation
Missed during the org migration — discussions and SECURITY links still pointed at callenflynn/CalOS. Co-Authored-By: Codebuff <noreply@codebuff.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Running
fastfetchreports the base Bluefin distro ("Bluefin stable") and uses the inherited logo instead of the CalOS ASCII logo.Root causes found (verified against fastfetch's source):
/etc/os-releaseFIRST, only falling back to/usr/lib/os-releasewhen fields are missing. The image only overlaid/usr/lib/os-release, so if the base ships a plain/etc/os-release, installed systems keep reporting the base distro.FASTFETCH_CONFIGis not a real fastfetch feature — there is no such env var anywhere in fastfetch's source (config resolution is--config+fastfetch/config.jsoncin~/.config,$HOME,$XDG_CONFIG_DIRS,/etc/xdg,/etc). The build shipped dead env exports that made it look like the CalOS preset was being forced when it never was.Changes
build_files/build.sh:ln -sf ../usr/lib/os-release /etc/os-releaseso branding always wins; remove the deadFASTFETCH_CONFIGexports; document the real mechanism. The system-wide/etc/fastfetch/config.jsonc+/etc/skel+presets/calos.jsonclayout was already correct — fastfetch does honor/etc/fastfetch/config.jsoncfor users without their own~/.configcopy.freebuff/BRANDING_SYSTEM.md: corrected the fastfetch configuration description.docs/latest-release.js,docs/script.js,README.md,build-disk.ymlcomments: bumped stale release examples from v1.1.4 → v1.1.5.Note for existing installs
New users and users without a private
~/.config/fastfetch/config.jsoncwill get the CalOS logo + "CalOS" immediately after updating. Users with an existing personal fastfetch config keep their own config (correct behavior) — delete~/.config/fastfetchto restore the CalOS default. An update is required for the fixes to land (ujust update/bootc upgrade).