Skip to content

Fix rechunk OCI import path in NVIDIA amd64 build - #51

Merged
callenflynn merged 2 commits into
mainfrom
copilot/fix-build-nvidia-amd64-failure
Sep 8, 2026
Merged

callenflynn merged 2 commits into
mainfrom
copilot/fix-build-nvidia-amd64-failure

Conversation

Copilot AI commented Sep 8, 2026 •

Copy link
Copy Markdown
Contributor

The Build nvidia (amd64) GitHub Actions job was failing during just rechunk after Chunkah output generation. The failure came from podman pull oci:... not reliably registering the imported image in container storage (image not known).

  • Root cause

    • Rechunk flow imported Chunkah OCI output via podman pull oci:<dir>, then attempted to tag the returned digest/image reference.
    • In CI, that pull path intermittently produced an unresolvable image reference.
  • Change

    • Switched OCI import in Justfile rechunk recipe from podman pull to explicit skopeo copy into containers-storage.
    • Assigned a deterministic local tag for the imported image before final retagging to ${target_image}:${tag}.
  • Behavioral impact

    • Keeps the rechunked artifact flow the same (import → tag for downstream steps), but removes dependency on the failing podman pull oci: resolution path in GitHub Actions.
CHUNKED_IMAGE="localhost/${target_image}:${tag}-chunked"
skopeo copy "oci:${CHUNKAH_OUTPUT_DIR}/chunked" "containers-storage:${CHUNKED_IMAGE}"
podman tag "${CHUNKED_IMAGE}" "${target_image}:${tag}"

Copilot AI lite review requested due to automatic review settings September 8, 2026 20:33

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Co-authored-by: callenflynn <170468817+callenflynn@users.noreply.github.com>
Copilot AI review requested due to automatic review settings September 8, 2026 20:36

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The update introduces a new skopeo dependency in just rechunk that is not installed by the CI workflow and is likely to break the GitHub Actions build.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Lite

Comment thread Justfile
Comment on lines +188 to 190
CHUNKED_IMAGE="localhost/${target_image}:${tag}-chunked"
skopeo copy "oci:${CHUNKAH_OUTPUT_DIR}/chunked" "containers-storage:${CHUNKED_IMAGE}"
podman tag "${CHUNKED_IMAGE}" "${target_image}:${tag}"
Copilot AI changed the title [WIP] Fix failing GitHub Actions job Build nvidia (amd64) Fix rechunk OCI import path in NVIDIA amd64 build Sep 8, 2026
Copilot AI requested a review from callenflynn September 8, 2026 20:39
@callenflynn
callenflynn marked this pull request as ready for review September 8, 2026 20:40
@github-actions github-actions Bot added the build label Sep 8, 2026
@callenflynn
callenflynn merged commit 6529049 into main Sep 8, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants