Repository navigation
fix: verify startup and download docs and resolve CI failures - #430
Open
NanaseInori wants to merge 6 commits into
Open
NanaseInori wants to merge 6 commits into
NanaseInori wants to merge 6 commits into
Conversation
This was referenced Oct 21, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Copying the old CONTRIBUTING examples sets 16- and 19-byte tokens, so the API rejects startup (minimum: 32 bytes). The four public download guides also still point to September's preview and say no Mac package exists, although v1.0.0-preview.20261020 ships a Windows EXE and both Mac DMGs.
Donesignals the end of the first cleanup attempt;Closeverifies completion and supports retry. Keep the cancellation deadline and blocked authority callback, reject further actions, and explicitly require verified process cleanup and profile removal before releasing the callback. Add a deterministic test of the pending-cleanup/retry contract.Validation
go mod verify,go mod tidy -diff, andgo test -p 1 -count=1 ./internal/releasegate ./cmd/releasegen.govulncheck@v1.6.0 ./...with Go 1.26.10 and the 2026-10-21 database: zero reachable vulnerabilities.go test -p 1 -race -count=1 ./internal/browserruntime, including the deterministic cleanup retry test.git diff --check.db8fdfb: all three jobs passed with Go 1.26.10, including actual Linux/Bash and Windows/PowerShell 5.1 startup and Chromium connection. The Linux smoke test also passed locally.db8fdfb: dependency/license gate, Windows packaging and both Mac architecture jobs passed; signing and publication skipped normally for the PR.db8fdfb: full CI 39555547564 passed all 23 jobs, including Go tests/vet, race checks, vulnerability audit, both native Mac jobs, Windows Desktop, real Edge UI, LSP, Store shards and both aggregate gates. All three workflows are green: 30 successful jobs and 2 normal PR publication/signing skips.The local environment is Linux; native Mac and Windows behavior is verified by GitHub's platform jobs. PR runs skip signing/publication and create no public release.
Surface governance
N/A — no Surface change.
Audit
2026-10-27 整合验证:已合并最新 main 与 #501 依赖修复,解决四份文档中的 Node 版本冲突,并将新增文档 CI 的 Node 同步到主线 24.22.1。下载文档检查与8项回归测试通过;本机按 CONTRIBUTING 原始 PowerShell 命令实际启动 Go API、Vite 和 Chromium,令牌权限边界、代理和连接页验证通过(
node scripts/check-contributor-startup.mjs)。已推送 168a2dc;新 CI 正在运行,未发布 Release。