ci: fail workflow on FATAL/ERROR/WARNING in Cacti log - #385
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Handle grep read failures separately so the log is always validated.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds a CI check that fails when cacti.log contains FATAL:, ERROR:, or WARNING: entries.
Changes:
- Scans the Cacti log after displaying it.
- Reports matches and fails the workflow.
File summaries
| File | Summary |
|---|---|
.github/workflows/plugin-ci-workflow.yml |
Adds Cacti log error detection; grep read errors may currently be treated as successful checks. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
xmacan
approved these changes
Sep 15, 2026
xmacan
previously approved these changes
Sep 15, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
bmfmancini
previously approved these changes
Sep 16, 2026
Replace plugin-ci-workflow.yml with plugin_evidence's version (renamed to intropage), adding a dedicated Run Pest Unit Tests step against Cacti's own Composer-managed vendor tree. Replace tests/bootstrap.php with tests/bootstrap-unit.php, tests/TestCase.php and tests/.cacti-version copied from plugin_evidence, and update phpunit.xml accordingly. Remove the now-unused plugin-local composer.json since tests run via Cacti's vendor/bin/pest.
…pers intropage_device_scope()/intropage_get_allowed_devices() call get_simple_device_perms(), get_allowed_devices(), read_user_setting(), set_user_setting() and cacti_count(), none of which were stubbed for the unit tests, causing 'Call to undefined function get_simple_device_perms()' once Pest actually ran in CI.
bmfmancini
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new step after View Cacti Logs that greps the full
cacti.logfor the stringsFATAL:,ERROR:,WARNING:and fails the job if any are found.