Fix plugin CI workflow - #95
Merged
Merged
Conversation
TheWitness
requested review from
bmfmancini,
browniebraun,
netniV,
somethingwithproof and
xmacan
September 12, 2026 13:39
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The workflow may not test the PHP version specified by the matrix.
Pull request overview
Updates the plugin CI workflow to test supported PHP versions and use the available Apache PHP package.
Changes:
- Removes PHP 8.1 from the test matrix.
- Replaces the versioned Apache PHP package with
libapache2-mod-php.
File summaries
| File | Summary |
|---|---|
.github/workflows/plugin-ci-workflow.yml |
Moderate (1 vote): Generic package installation may cause sudo php to use the distro-default PHP instead of the matrix version. Use the setup-php binary consistently or configure the selected version. |
Review details
Suppressed comments (1)
.github/workflows/plugin-ci-workflow.yml:88
- This package resolves to Ubuntu's default PHP Apache module, not
${{ matrix.php }}. The workflow later runs Cacti setup and polling withsudo phpand stores/usr/bin/php, so the 8.2 and 8.4 jobs will use the distro default (typically 8.3) for those steps and no longer test the PHP version named by the matrix. Use thesetup-phpbinary consistently for the sudo/configured invocations, or otherwise configure the selected version before those steps.
run: sudo apt-get install -y apache2 snmp snmpd rrdtool fping libapache2-mod-php
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
bmfmancini
previously approved these changes
Sep 12, 2026
bmfmancini
approved these changes
Sep 12, 2026
bmfmancini
previously approved these changes
Sep 12, 2026
Removed apache2 from the list of system dependencies.
Added environment variable CACTI and conditional checks for PHPStan and linting tasks based on its value.
bmfmancini
approved these changes
Sep 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the plugin CI workflow (.github/workflows/plugin-ci-workflow.yml):
Recreates the fix from #94, which was closed.