Skip to content

Fix plugin CI workflow - #95

Merged
TheWitness merged 6 commits into
mainfrom
fix/ci-failures
Sep 12, 2026
Merged

Fix plugin CI workflow#95
TheWitness merged 6 commits into
mainfrom
fix/ci-failures

Conversation

@TheWitness

@TheWitness TheWitness commented Sep 12, 2026

Copy link
Copy Markdown
Member

Fixes the plugin CI workflow (.github/workflows/plugin-ci-workflow.yml):

  • Limits the PHP test matrix to 8.2, 8.3, 8.4 (removes 8.1, which is no longer supported).
  • Installs the generic apache2 libapache2-mod-php package instead of a version-suffixed package name that no longer resolves.
  • Pins the Cacti checkout to the 1.2.x branch instead of the default branch, so tests run against the stable release line.

Recreates the fix from #94, which was closed.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The workflow may not test the PHP version specified by the matrix.

Pull request overview

Updates the plugin CI workflow to test supported PHP versions and use the available Apache PHP package.

Changes:

  • Removes PHP 8.1 from the test matrix.
  • Replaces the versioned Apache PHP package with libapache2-mod-php.
File summaries
File Summary
.github/workflows/plugin-ci-workflow.yml Moderate (1 vote): Generic package installation may cause sudo php to use the distro-default PHP instead of the matrix version. Use the setup-php binary consistently or configure the selected version.
Review details

Suppressed comments (1)

.github/workflows/plugin-ci-workflow.yml:88

  • This package resolves to Ubuntu's default PHP Apache module, not ${{ matrix.php }}. The workflow later runs Cacti setup and polling with sudo php and stores /usr/bin/php, so the 8.2 and 8.4 jobs will use the distro default (typically 8.3) for those steps and no longer test the PHP version named by the matrix. Use the setup-php binary consistently for the sudo/configured invocations, or otherwise configure the selected version before those steps.
      run: sudo apt-get install -y apache2 snmp snmpd rrdtool fping libapache2-mod-php
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

bmfmancini
bmfmancini previously approved these changes Sep 12, 2026
bmfmancini
bmfmancini previously approved these changes Sep 12, 2026
Removed apache2 from the list of system dependencies.
@TheWitness
TheWitness merged commit bbc1e82 into main Sep 12, 2026
3 checks passed
@TheWitness
TheWitness deleted the fix/ci-failures branch September 12, 2026 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants