fix: Reindex issue with data queries - #623
Merged
Merged
Conversation
TheWitness
requested review from
bmfmancini and
xmacan
and
a lite review from Copilot
September 18, 2026 01:25
bmfmancini
previously approved these changes
Sep 18, 2026
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The reindex logic and changelog issue reference need correction.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
This pull request updates Spine’s reindex calculation for data queries and documents the fix.
Changes:
- Refactors reindex comparisons and RECACHE logging in
poller.c. - Adds a 1.2.32 release note in
CHANGELOG.
File summaries
| File | Summary |
|---|---|
poller.c |
Reindex comparison and uptime rollback issues remain unresolved. |
CHANGELOG |
Release note references issue #623 instead of #622. |
Review details
Suppressed comments (1)
poller.c:210
- These operands are used for every ordered
poller_reindexassertion, not only uptime. Assigningatoll()results tounsigned long longwraps negative sensor/count values to very large positives, so comparisons can be reversed when values cross zero and recaching can be missed or triggered incorrectly. Keep these temporaries signed (or restrict the unsigned type to validated uptime values).
unsigned long long previous_uptime = 0;
unsigned long long curr_uptime = 0;
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Update CHANGELOG with recent version changes and issues. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
bmfmancini
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This corrects the issues with the Reindex method calculation in spine.
Closes #622