Repository navigation
#port-1x-s3trait-methods Port setPublicPermissions, listFilesWithUrls, listFiles from 1.x - #11
Merged
Merged
Conversation
…, listFiles from 1.x; add unit tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports three S3Trait methods present in the
1.next-cake4branch (PRs #5 and #7) but missing from2.next-cake5:setPublicPermissions(string $key)— setspublic-readACL on an S3 objectlistFilesWithUrls(string $prefix, int $maxKeys)— lists objects and appends a presigned GET URL to eachlistFiles(string $prefix, int $maxKeys)— lists objects filtered by prefixMethods are adapted to the
2.nextconventions: usegetS3Client(),Configure::readOrFail(), and typed closures.AwsExceptionis caught and re-thrown as a plainExceptionwith a descriptive message.Test Plan
vendor/bin/phpunit tests/TestCase/Util/S3TraitTest.php --no-coverage— 11 tests, 22 assertions, all greenvendor/bin/phpcs src/Util/S3Trait.php tests/TestCase/Util/S3TraitTest.php— no violations