Repository navigation
docs: .env.example says Arcade is the default broadcaster (the stable docs patch PR 312's review asked for) - #320
Merged
Merged
Conversation
… the cold review's finding 1) The three blocks still described the old default: classic ARC unless ARC_MODE=arcade or ARCADE=1 enabled Arcade, and the TAAL keys as Arcade mode's TAAL failover. Under #300 all three are false. They now match README's broadcaster section: ARC_MODE unset is Arcade, the default; classic is deprecated and the hermetic stub's until #299; ARCADE is the older switch, read only when ARC_MODE is unset; ARC_URL has no testnet Arcade default (a testnet wallet in Arcade mode without it is refused by name); the TAAL keys are classic only, deprecated, and logged once as unused in Arcade mode (toolbox #317). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 0e339dd) (cherry picked from commit 24daddd)
…re-check, ruling (b)) The re-check's one finding: line 9 said "Unset, blank or `arcade` (any case) is Arcade", but the code reads a blank ARC_MODE as unset and ARCADE then decides (ARC_MODE= with ARCADE=0 runs classic, on main too); README's broadcaster section has it right. The line now says so. A docs-only fold on the MERGE verdict, under the 2026-10-26 ruling (b). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> (cherry picked from commit bef225c)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs only, the stable line. PR 312's cold review on beta found
.env.examplestill describing classic ARC as the default under #300 (main has the same stale text; neither PR 302 nor PR 312 touched the file) and asked that the rewrite be carried to main as a stable docs patch. The two commits are cherry-picks of the reviewed ones on beta: the three blocks match README's broadcaster section (ARC_MODEunset or blank is Arcade, withARCADEdeciding whenARC_MODEis blank;classicdeprecated, the hermetic stub's until #299;ARC_URLwith no testnet Arcade default; the TAAL keys classic only, deprecated and logged as unused in Arcade mode). Nothing else moves.Refs #300.
🤖 Generated with Claude Code