Conversation
|
@Seermad1 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Thanks for the contribution! We reviewed this PR while merging the open queue and couldn't merge it yet. Here's what needs fixing:
This branch also has merge conflicts with |
…ving-continue-on-error Resolves merge conflicts against CalloraOrg/Callora-Backend@1518ce6 (68 commit(s) behind) so the PR is mergeable.
Author
|
@greatest0fallt1me thanks for the review — pushed a fix to this branch. What changed:
Head: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR removes the
continue-on-error: trueescape hatches from the CI workflow so that lint, typecheck, and build failures actually fail the pipeline. It also wires the full Jest suite into CI by adding unit and integration test steps, provisions a Postgres service container for integration tests, and uploads a coverage artifact with a minimum threshold enforced by Jest.Related Issue
Changes
🚦 CI Gate Enforcement
[MODIFY]
.github/workflows/ci.ymlcontinue-on-error: truefrom thebuildjob and from thelint,typecheck, andbuildsteps so failures now block merge.postgres:16) with health checks so integration tests have a real database to run against.npm run test:unitandnpm run test:integrationsteps, withDATABASE_URLwired to the service container for integration tests.npm run test:coveragestep and an artifact upload step that publishes the coverage summary for review.[MODIFY]
package.jsontest:unit,test:integration, andtest:coveragescripts so CI can invoke the full Jest suite with the right project split and coverage flags.[MODIFY]
jest.config.cjsunitandintegrationprojects so the two suites can be invoked independently in CI.Verification Results
continue-on-errorremoved from thetypecheckstepnpm run test:unitstep added to the workflownpm run test:integrationstep addednpm run test:coverage+ artifact upload step addedSecurity and Failure-Mode Handling
continue-on-errormeans a failing lint, typecheck, or build step now surfaces as a red check instead of a silent pass, closing the gap that let the duplicate-import entrypoint merge green.Compatibility Considerations
test:unit/test:integration/test:coveragescripts are additive; existingnpm testbehavior is preserved.Closes #1283