Skip to content

Support per-instrument Python packages - #28

Merged
mikelangmayr merged 2 commits into
mainfrom
mike/per-instrument-module-name
Sep 24, 2026
Merged

mikelangmayr merged 2 commits into
mainfrom
mike/per-instrument-module-name

Conversation

@mikelangmayr

@mikelangmayr mikelangmayr commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor
  • Add CAMERAD_MODULE_NAME, defaulting to camera_interface, which sets both the pybind11 module name and the target's OUTPUT_NAME so the import name and the built filename agree
  • Mark the Camera binding py::module_local(), without which two differently named builds still fail to import together with type "Camera" is already registered
  • Add packaging/tracking, a pyproject.toml that installs camera-interface-tracking providing the module camera_interface_tracking, with the instrument and module name fixed rather than passed by the caller
  • Document both in the README
  • Verified on macOS: the plain C++ build and the default module name are unchanged; camera-interface and camera-interface-tracking install into one environment and import together with distinct Camera types

@mikelangmayr mikelangmayr changed the title Make the Python module name a build option so instrument builds can coexist Support per-instrument Python packages Sep 22, 2026
@mikelangmayr
mikelangmayr merged commit a5e5112 into main Sep 24, 2026
4 checks passed
@mikelangmayr
mikelangmayr deleted the mike/per-instrument-module-name branch September 24, 2026 17:52
@github-actions

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-09-24 17:52 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants