Add preprocessing functions - #205
Merged
Merged
Conversation
sjavis
force-pushed
the
preprocessing
branch
3 times, most recently
from
June 2, 2026 10:00
9ce5cd0 to
f15b6b9
Compare
sjavis
marked this pull request as ready for review
June 2, 2026 10:01
MarionBWeinzierl
left a comment
MarionBWeinzierl
left a comment
Member
There was a problem hiding this comment.
Just had a quick look and some comments -- @surbhigoel77 , could you have a more thorough look through this PR?
Closed
Closed
Collaborator
Author
|
In fc12ab3 I have also added a correction for what I suspect is an error in This seems to resolve the issue in #156 when combined with updates to TSTORMS. This will be done in another PR. |
MarionBWeinzierl
left a comment
MarionBWeinzierl
left a comment
Member
There was a problem hiding this comment.
I am happy from my part, but leave it to @surbhigoel77 to accept this PR after she has done another review
surbhigoel77
approved these changes
Jul 7, 2026
Also fix issue by respecifying the netcdf backend
This makes all optional arguments consistent in needing to be passed by keyword. I think it also makes it clearer.
Return cf.Field objects instead of size-1 lists. Also allow size-1 lists to be passed as inputs to functions that expect single fields.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds preprocessing functions for all of the topics in the 'data preprocessing' page of the docs. Intended for use with the batching (#194). Generally the functions are designed to accept either file paths or
cf.Fieldinputs and return single or lists ofcf.Field. Each function can also write an output file by providing theoutput_fileargument.src/tctrack/preprocessing.pyesmpyis installed for regridding. Update the docs to reflect that this is now a "proper dependency".Closes #189