Fixes to demo made with Felipe - #88
Draft
Saaketh0 wants to merge 3 commits into
Draft
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Portfolio workflow indexed a Future instead of blocking on its value. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Member
|
Is this ready ? |
Place generated agent stubs both flat and at their entrypoint-mirrored path in agent and workflow Docker contexts, so both 'from price_agent import PriceAgent' and 'from agents.price_agent import PriceAgent' style peer imports resolve. _stub_destination() only ever wrote one destination, contradicting the two comments in cli.py that already claimed dual placement -- this is why MetricsAgent's container logged 'No module named price_agent'. Updated the one test that asserted the old (wrong) single-destination behavior. This same class of bug and fix (ac9a75e, 01a70f2, 137e1db, 0b9546c) has recurred across several unmerged branches; none reached main. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Saaketh0
force-pushed
the
CAN-334-Debug-Session-Fixes
branch
from
September 10, 2026 18:59
6081c87 to
9f86d75
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP