Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When canyonos deploy is ran and stopped, any subsequent canyonos tests will cause unexpected errors to the program. This is due to the fact that canyonos stop didn't remove the containers, just stopped them, unlike quit, resulting in canyonos test trying to access the containers and erroring because those containers are stopped.
This was a deeper issue with overlap between canyonos test and deploy, and I decided to try to completely decouple canyonos test deploys with the actual deploy path. This involves launching canyonos test with completely different containers, being prefixed with "test" and being located on the 9000 port range (not the best fix, but good for now). This allows test to occupy different containers from deploy, with no risk of clobbering/getting clobbered by anything.
I also set canyonos test to delete all test containers immediately upon exit, its a bandage solution in the sense of being unable to debug containers if it fails as they get shut down, but something i did for simplicity.