ci: build the CLI release through turbo and narrow the release trigger - #136
Draft
userAugustos wants to merge 21 commits into
Draft
userAugustos wants to merge 21 commits into
userAugustos wants to merge 21 commits into
Conversation
The release jobs build the wheel with bun run build and the binaries with a new build:binary turbo task. Nuitka is pinned through a release dependency group of the CLI package. Tests, docs, and the install script under packages/cli no longer start a release.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…ublishing the image uv appends the project name to the check url, so it must be the index root. Core test and doc changes no longer rebuild the runtime image.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #129. Stacked on #135: the base of this PR is the #135 branch, so the diff shows only this change.
Summary
bun run build --filter=canyonos. On a release runner there is no turbo cache, so this always runsuv build --package canyonos. The publish step passes--check-urlso a rerun after a partial failure does not fail on a file that is already uploaded.build:binaryturbo task that holds the Nuitka command. The per-OS asset name reaches--output-filenamethrough turbo's--passthrough. The task is uncached because a turbo hash does not include the runner OS.uv.lockthrough areleasedependency group of the CLI package. A plainuv syncskips that group; the release job syncs it explicitly.packages/cli/tests, Markdown files, andinstall.sh. A change that ships nothing no longer cuts a release. The version bump still refreshesuv.lockin the same commit.packages/corewith per-package triggers, and a turbo wrapper would cache nothing for a pushed multi-arch image.install.sh, and the Homebrew formula are unchanged.Test
bun run build --filter=canyonosfrom a checkout with no.venvwrites onlydist/canyonos-*.uv sync --lockeddoes not install nuitka;uv sync --locked --package canyonos --group releasedoes.bun run build:binary --filter=canyonos --dry-run=json -- --output-filename=xshows the Nuitka command with the passthrough argument.cli-release.ymlagainst an existing tag rebuilds and reattaches the four binaries.bun run checkandbun run testpass.Review Focus
.github/workflows/cli-release.yml: the three replaced steps and the--passthrough..github/workflows/cli-release-tag.yml: the negatedpathsand the[skip release]guard, which the bump commit still needs becausepackages/cli/pyproject.tomlstays a released path.turbo.json: thebuild:binarytask is the single source of the Nuitka flags.Known and accepted
cli-release.yml.mainare not conventional commits, PRs land as merge commits, and release-please does not updateuv.lock.macos-15-intelrunner label as unknown. The label is valid; the linter's list is stale.