Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Saaketh0
marked this pull request as ready for review
September 18, 2026 20:19
Saaketh0
added
Non-Critical Fix
Keeps this branch's Local provider decision (always localhost, no host/user override) over main's generalization -- Local/_runtime.py resolved to our side, and the three tests that only existed to cover main's now-dropped host/user override + api_port-conflict-detection feature (_is_local_host/_port_bound) were removed or trimmed to match. test_global_controller_redis_reuse.py's host/user-override test kept both fields from each side, since neither was actually in conflict -- the test already exercises exactly what it's named for either way. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deploying specifically to EC2 does not have good documentation, and the process was outdated. I updated the docs to make it easier for someone to launch their project on EC2.
While doing that, I noticed a bunch of old code that could be simplified/removed entirely, and simplified the EC2 path to reduce user requirements, as well as make the process more seamless.
Additions: