Conversation
…nyonos skill V030/V031 gated on canyonos_core capabilities that never actually vary: env_file injection is now unconditional in global_controller.py, and editable_install (_install_step) has never existed in canyonos_core's history. Treat both as fixed facts instead of probing for them, and document the otel.destinations key that global_controller.yaml already supports but the skill never mentioned. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Both are real config keys global_controller.py reads off self.config, found by a coverage check being added in CAN-282's contract-tests work (#95): every top-level config key the controller reads must have a row in this table, the same class of gap that let otel.destinations go undocumented in this PR. - cleanup_interval: developer-set, defaults to 10 like poll_interval. - project_id: derived, not developer-set -- the controller generates and persists a UUID on first load when absent, so omitting it is not an error.
nickhuo
force-pushed
the
nickhuo/porting-skill-ci-contract
branch
from
September 11, 2026 00:02
c39e78f to
80d0a37
Compare
canyonos_core's runtime contract changes faster than the porting-to-canyonos skill's docs and validators track it (see 76b5a45, #83). Pin the skill's factual claims to executable assertions against real canyonos_core source instead of hand-maintained prose, and run them where they can actually block a PR: - tests/test_porting_skill_contract.py: behavior assertions for claims in manifest.md/runtime-contract.md, plus a coverage check that diffs every top-level config key canyonos_core reads off `self.config` against manifest.md's ownership table -- the same class of gap that let otel.destinations go undocumented. It found two more real gaps (project_id, cleanup_interval); those manifest.md rows are documented in #86 rather than here, since that's the PR already carrying this skill's doc fixes. - .github/workflows/ci.yml: actually run `pytest`. It never had before. - tests/conftest.py: compile the gRPC stubs global_controller.py imports at module load time, so importing it from a plain checkout doesn't require a prior `canyonos build`. This was blocking collection of 11 existing test files, which is almost certainly why pytest was never wired into CI. - tests/test_cli.py: three deploy tests globally monkeypatched `os.path.isfile` truthy, which also fooled resolve_env_file's unrelated platform-secrets check. Patch resolve_env_file directly instead.
nickhuo
force-pushed
the
nickhuo/porting-skill-ci-contract
branch
from
September 11, 2026 00:05
80d0a37 to
2b52054
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add CI tests that verify the claims in the porting-to-canyonos skill docs, especially manifest.md (configuration) and runtime-contract.md against the actual behavior of canyonos_core.
Run these tests on every PR. If the code changes and no longer matches the docs, CI should fail. The docs must then be updated manually before the PR can be merged.