Repository navigation
Pin json below 3 for Active Record 8.0 test runs - #602
Merged
Merged
Conversation
Active Record 8.0.5.1 calls JSON.generate with quirks_mode, which json 3 rejects with "unknown keyword: quirks_mode". Every Active Record 8.0 CI job fails on the specs that save a JSON attribute. 8-0-stable already dropped the option in rails/rails@2786de2, but no 8.0 release includes it yet. Constrain json only when the requested Active Record version allows 8.0.5.1, so Active Record 8.1 runs keep testing json 3.
There was a problem hiding this comment.
🟢 Approval recommended
The targeted constraint addresses the affected test configuration without restricting Active Record 8.1 jobs.
0 open findings
What changed in this PR
Adds a targeted dependency workaround for Active Record 8.0 test failures caused by json 3 rejecting quirks_mode.
Changes:
- Pins json below 3 when
ACTIVE_RECORD_VERSIONpermits 8.0.5.1, leaving 8.1 jobs unrestricted. - Documents when the temporary pin can be removed.
| File | Description |
|---|---|
| Gemfile | Adds the conditional json constraint and explanatory comments. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Active Record 8.0.5.1 calls
JSON.generatewithquirks_mode, and json 3 rejects that option withunknown keyword: quirks_mode. As a result, every Active Record 8.0 job onmasterfails in the two specs that save a JSON attribute.8-0-stablealready stopped passing the option in rails/rails@2786de2, but no 8.0 release includes that fix yet. This pins json below 3 only whenACTIVE_RECORD_VERSIONallows 8.0.5.1, so Active Record 8.1 jobs keep testing json 3. The pin can be dropped once an 8.0 release ships the fix.