Skip to content

Fix: prevent logo theme animation from restarting - #105

Merged
mergify[bot] merged 1 commit into
mainfrom
fix/logo-theme-flicker
Nov 13, 2026
Merged

mergify[bot] merged 1 commit into
mainfrom
fix/logo-theme-flicker

Conversation

@Ceebug

@Ceebug Ceebug commented Nov 13, 2026

Copy link
Copy Markdown
Owner

Summary

  • Track the last observed dark/light state.
  • Ignore body class mutations that do not change the active theme, preventing theme-switching cleanup from restarting the logo animation.

Root cause

The body observer ran for every class mutation. Removing theme-switching therefore replayed the logo's brightness animation even though the theme had not changed.

Validation

The observer now returns before starting an animation whenever the dark/light state is unchanged. This preserves the existing animation for real theme changes while ignoring transition cleanup.

@mergify

mergify Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Queue requested — the merge queue status continues in this comment ↓.

@mergify

mergify Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

✅ Merged into main as b05a76b at 15:28 UTC

1 min in the queue, with no time running CI.

So far

1 merge condition met
  • check-success=CI: Test/Lint

Times in UTC · dashboard · how the merge queue works

@mergify mergify Bot added the queued Part of @MergifyIO, used to indicate a pr has been queued for merging label Nov 13, 2026
@mergify
mergify Bot merged commit b05a76b into main Nov 13, 2026
2 checks passed
@mergify mergify Bot removed the queued Part of @MergifyIO, used to indicate a pr has been queued for merging label Nov 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant