Repository navigation
Conversation
- Docs: the default admin approval threshold is 100,000 sats. - Replace the underTest() os.Args check with CheckLnbitsConfiguration(), called from main at startup instead of from package init. - Give settlement checks their own lnbits rate limiter (60/min) so analytics traffic (now 120/min) cannot starve them.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #72. These fixes for @rayaanr's nits were pushed after #72 was merged, so they did not reach
main.Changes
internal/config.goandconfig.yaml.example). Sample responses updated.underTest()removed: the "please configure a lnbits url" check is nowinternal.CheckLnbitsConfiguration(), called frommain()at startup instead of packageinit. Production still panics without a url; tests no longer need a full config to load thelnbits -> satdress -> network -> internalimport chain.WaitForOutgoingPaymentandPriorPaymentuse their own limiter (60/min, burst 3). Analytics keepsRateLimiter, lowered from 150/min to 120/min so the total stays under the 200/min lnbits limit.Testing
go build ./...passes.internal/lnbits,internal/utilsandinternal/apitests pass (internal/apistill needstranslations/in the package dir).🤖 Generated with Claude Code