Skip to content

fix: address invoice payment review nits - #73

Open
xbuddhi wants to merge 1 commit into
mainfrom
xbuddhi/fix/invoice-review-nits
Open

xbuddhi wants to merge 1 commit into
mainfrom
xbuddhi/fix/invoice-review-nits

Conversation

@xbuddhi

@xbuddhi xbuddhi commented Oct 21, 2026

Copy link
Copy Markdown

Follow-up to #72. These fixes for @rayaanr's nits were pushed after #72 was merged, so they did not reach main.

Changes

  • Docs: the default admin approval threshold is 100,000 sats (matches internal/config.go and config.yaml.example). Sample responses updated.
  • underTest() removed: the "please configure a lnbits url" check is now internal.CheckLnbitsConfiguration(), called from main() at startup instead of package init. Production still panics without a url; tests no longer need a full config to load the lnbits -> satdress -> network -> internal import chain.
  • Separate settlement rate limiter: WaitForOutgoingPayment and PriorPayment use their own limiter (60/min, burst 3). Analytics keeps RateLimiter, lowered from 150/min to 120/min so the total stays under the 200/min lnbits limit.

Testing

  • go build ./... passes.
  • internal/lnbits, internal/utils and internal/api tests pass (internal/api still needs translations/ in the package dir).

🤖 Generated with Claude Code

- Docs: the default admin approval threshold is 100,000 sats.
- Replace the underTest() os.Args check with CheckLnbitsConfiguration(),
  called from main at startup instead of from package init.
- Give settlement checks their own lnbits rate limiter (60/min) so
  analytics traffic (now 120/min) cannot starve them.
@coderabbitai

coderabbitai Bot commented Oct 21, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 4302294f-b451-4bfc-b6f5-6c23282a7d94
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant