[LesnyRumcajs]

The step guarded against MpoolSelect panics from non-total sort comparators and gas-limit underflow. Both are fixed, and comparator total order is covered by unit tests, while the step cost ~6 minutes of the 30-minute calibnet check budget.

Summary of changes

Changes introduced in this pull request:

• drop mpool killer as it's not killing anything anymore, there are different tests elsewhere and and it saves quite a bit of compute time on every run

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

• I have performed a self-review of my own code,
• I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
• I have added tests that prove my fix is effective or that my feature works (if possible),
• I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Outside contributions

• This pull request is based on an issue that a maintainer has accepted (see Before Opening a Pull Request).
• I have read and agree to the CONTRIBUTING document.
• I have read and agree to the AI Policy document. I understand that failure to comply with the guidelines will lead to rejection of the pull request.

Summary by CodeRabbit

• Tests
  • The Calibnet check no longer runs the mempool selection regression test.

[coderabbitai]

No actionable comments were generated in the recent review.

Walkthrough

The calibnet check no longer runs the mempool selection regression test. The Ruby script that sent Filecoin.MpoolSelect requests is also removed.

Changes

MpoolSelect test removal

Layer / File(s)	Summary
Remove the regression test and helper scripts/tests/calibnet_other_check.sh, scripts/mpool_select_killer.rb	The calibnet check no longer installs the http gem or sends chain-head data to the helper script. The helper script is removed.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Suggested labels: RPC

Merge Risk: Minimal · up to 480c6

This removes a CI test step and its Ruby helper, with no change to production behavior. The main trade-off is less end-to-end regression coverage for MpoolSelect, which the author says unit tests now cover. Merge risk is minimal.

Pre-merge checks: 5

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly states that the pull request removes the mpool_select_killer regression step from CI.
Docstring Coverage		No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files.

Finishing Touches

Generate docstrings

• Commit to this branch
• Create a new PR

Generate unit tests (beta)

• Commit to this branch
• Create a new PR

Simplify code

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Linked repositories: skipped filecoin-project/lotus. Repositories added from the pull request branch configuration require the pull request author (and the user who triggered the review, when different) to have read access to them.

Recent review info

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Repository UI
• Review profile: CHILL
• Plan: Essentials
• Run ID: 26249169-9574-42d9-99c4-b8194ebfd9a1

Commits

Reviewing files that changed from the base of the PR and between 40d695b and 480c679.

Files selected for processing: 2

• scripts/mpool_select_killer.rb
• scripts/tests/calibnet_other_check.sh

Files with no reviewable changes: 2

• scripts/tests/calibnet_other_check.sh
• scripts/mpool_select_killer.rb

Included review availability: This review used your included allowance. 4 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.60%. Comparing base (40d695b) to head (480c679).
✅ All tests successful. No failed tests found.

Additional details and impacted files

see 15 files with indirect coverage changes

---

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40d695b...480c679. Read the comment docs.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.