Added service label cmk/mssql_recovery_type for mssql_backup services - #949
Open
lbuhleie wants to merge 1 commit into
Open
Added service label cmk/mssql_recovery_type for mssql_backup services#949lbuhleie wants to merge 1 commit into
lbuhleie wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General information
This changes the MSSQL Backup service discovery to also discover a service label, based on the recovery type of the SQL instance.
Proposed changes
Prior to this, the MSSQL Backup service would only discover the service. With this, there is a new service label being discovered for those services: "cmk/mssql_recovery_type":
This enables Checkmk administrators to easily set different thresholds for MSSQL backup services based on the recovery type. For example, Checkmk administrators can now create one rule that only matches on Instances with the recovery type SIMPLE, that disables thresholds for the Log backup.
Prior to this, such a rule would have to be set on each host and instance individually.
I already did a Pull Request for this (#909), but some Pipelines failed and I lost track of it. So this is the second attempt for this.