Fixed a bug in signl4 notification plugin that would crash the script if there are non-ascii characters in the service description - #950
Open
lbuhleie wants to merge 1 commit into
Conversation
… if there are non-ascii characters in the service description
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General information
This fixes a small bug in the signl4 notification plugin, being caused by non-ascii characters in the service description of alerts.
Bugreport
When a service alert triggers the signl4 notification plugin and this service contains non-ascii characters (e.g. umlauts), the notification plugin would crash.
Proposed changes
I fixed this by defining the behaviour on errors within the
encodefunction to replace those non-ascii characters with a "?". So now instead of crashing the service description will be slightly altered.Example:
A service like "Log C:\temp\Domänen-Admins.log)" will now report via signl4 with the service description "Log C:\temp\Dom?nen-Admins.log".