Skip to content

Fix iPad page navigation duplication - #42

Merged
Chefski merged 3 commits into
devfrom
codex/fix-ipad-page-navigation
Sep 1, 2026
Merged

Fix iPad page navigation duplication#42
Chefski merged 3 commits into
devfrom
codex/fix-ipad-page-navigation

Conversation

@Chefski

@Chefski Chefski commented Sep 1, 2026

Copy link
Copy Markdown
Owner

Summary

  • route page selections to the detail column on regular-width iPad layouts
  • keep compact iPhone navigation using the existing push stack
  • apply the same behavior to page tree, recent/favorite links, and notifications

Verification

  • swiftlint lint --strict (691 files, 0 violations)
  • xcodebuild -project docmostly.xcodeproj -scheme docmostly -destination "generic/platform=iOS Simulator" build CODE_SIGNING_ALLOWED=NO
  • runtime verified on iPad and iPhone simulators before commit
  • git diff --check

@greptile-apps

greptile-apps Bot commented Sep 1, 2026

Copy link
Copy Markdown

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
docmostly/Features/Spaces/MainShellView.swift Injects size-class-dependent page presentation across the iOS split-view hierarchy.
docmostly/Features/Spaces/MainShellContentView.swift Preserves the content NavigationStack while extracting its root destination switch into a dedicated view.
docmostly/Features/PageReader/PageOpenTarget.swift Routes page links either through stack navigation or AppState-driven detail-column selection.
docmostly/Features/PageTree/PageTreeNodeView.swift Applies the same presentation-aware routing to page-tree nodes.
docmostly/Features/Notifications/NotificationListRow.swift Makes notification page opening presentation-aware while retaining unread-state handling.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[User selects a page] --> B{Horizontal size class}
    B -->|Compact| C[Use NavigationLink]
    C --> D[Push page onto content stack]
    B -->|Regular| E[Use Button action]
    E --> F[Update AppState selected page]
    F --> G[Render page in detail column]
    H[Settings and non-page destinations] --> I[Content NavigationStack]
    I --> J[Push registered destination]
Loading

Reviews (2): Last reviewed commit: "fix: preserve content column navigation" | Re-trigger Greptile

Comment thread docmostly/Features/Spaces/MainShellContentView.swift Outdated

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

Re-trigger cubic

@Chefski Chefski closed this Sep 1, 2026
@Chefski Chefski reopened this Sep 1, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 1 file (changes from recent commits).

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread docmostly/Features/Spaces/MainShellContentView.swift
greptile-apps[bot]
greptile-apps Bot previously approved these changes Sep 1, 2026
@greptile-apps
greptile-apps Bot dismissed their stale review September 1, 2026 15:14

Dismissed because a newer commit was pushed; Greptile will re-review the current head.

@Chefski
Chefski merged commit 35542bf into dev Sep 1, 2026
9 checks passed
@Chefski
Chefski deleted the codex/fix-ipad-page-navigation branch September 1, 2026 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant