Fix iPad page navigation duplication - #42
Merged
Merged
Conversation
|
| Filename | Overview |
|---|---|
| docmostly/Features/Spaces/MainShellView.swift | Injects size-class-dependent page presentation across the iOS split-view hierarchy. |
| docmostly/Features/Spaces/MainShellContentView.swift | Preserves the content NavigationStack while extracting its root destination switch into a dedicated view. |
| docmostly/Features/PageReader/PageOpenTarget.swift | Routes page links either through stack navigation or AppState-driven detail-column selection. |
| docmostly/Features/PageTree/PageTreeNodeView.swift | Applies the same presentation-aware routing to page-tree nodes. |
| docmostly/Features/Notifications/NotificationListRow.swift | Makes notification page opening presentation-aware while retaining unread-state handling. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[User selects a page] --> B{Horizontal size class}
B -->|Compact| C[Use NavigationLink]
C --> D[Push page onto content stack]
B -->|Regular| E[Use Button action]
E --> F[Update AppState selected page]
F --> G[Render page in detail column]
H[Settings and non-page destinations] --> I[Content NavigationStack]
I --> J[Push registered destination]
Reviews (2): Last reviewed commit: "fix: preserve content column navigation" | Re-trigger Greptile
There was a problem hiding this comment.
All reported issues were addressed across 1 file (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
greptile-apps
Bot
dismissed
their stale review
September 1, 2026 15:14
Dismissed because a newer commit was pushed; Greptile will re-review the current head.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
swiftlint lint --strict(691 files, 0 violations)xcodebuild -project docmostly.xcodeproj -scheme docmostly -destination "generic/platform=iOS Simulator" build CODE_SIGNING_ALLOWED=NOgit diff --check