Skip to content

Release 1.0 iPad navigation fix - #43

Merged
Chefski merged 2 commits into
mainfrom
dev
Sep 1, 2026
Merged

Release 1.0 iPad navigation fix#43
Chefski merged 2 commits into
mainfrom
dev

Conversation

@Chefski

@Chefski Chefski commented Sep 1, 2026

Copy link
Copy Markdown
Owner

Promotes the tested iPad navigation fix from dev to main for the next Xcode Cloud release build.

Verification completed on the source PR:

  • iPad build
  • iOS and macOS unit tests
  • iOS and macOS UI smoke tests
  • SwiftLint, CRDT drift, and Git hygiene
  • focused iPad navigation and transition tests

* fix: open iPad pages in the detail column

* fix: preserve content column navigation

* fix: reconcile iPad navigation transitions
@greptile-apps

greptile-apps Bot commented Sep 1, 2026

Copy link
Copy Markdown

Confidence Score: 5/5

The PR appears safe to merge, with no concrete changed-code failure identified in the supported navigation paths.

Compact layouts retain NavigationStack-based page opening, regular-width layouts update the split view’s selected page directly, and the associated selection lifecycle behavior is consistent with those two presentation models.

Important Files Changed

Filename Overview
docmostly/Features/PageReader/PageOpenPresentation.swift Defines the environment-driven distinction between stack and detail-column page presentation and its cleanup policy.
docmostly/Features/PageReader/PageOpenTarget.swift Routes reusable page links through stack navigation or direct detail selection and applies presentation-aware cleanup.
docmostly/Features/PageTree/PageTreeNodeView.swift Uses direct detail-column selection for regular-width page-tree navigation while retaining stack links in compact layouts.
docmostly/Features/Notifications/NotificationListRow.swift Makes notification page opening presentation-aware while preserving unread-state updates.
docmostly/Features/Spaces/MainShellContentView.swift Extracts the content root view and clears obsolete stack navigation when switching into detail-column mode.
docmostly/Features/Spaces/MainShellView.swift Derives page presentation from the iOS horizontal size class and injects it throughout the split-view hierarchy.
docmostlyTests/PageReader/PageOpenPresentationTests.swift Verifies that stack readers clear selection while detail-column transitions preserve it.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[MainShellView reads horizontal size class] --> B{Compact layout?}
    B -->|Yes| C[PageOpenPresentation.stack]
    B -->|No| D[PageOpenPresentation.detailColumn]
    C --> E[NavigationLink pushes reader]
    E --> F[Reader disappearance clears matching selection]
    D --> G[Button updates AppState selection]
    G --> H[MainShellDetailView displays reader]
    H --> I[Reader disappearance preserves selection]
Loading

Reviews (1): Last reviewed commit: "Fix iPad page navigation duplication (#4..." | Re-trigger Greptile

greptile-apps[bot]
greptile-apps Bot previously approved these changes Sep 1, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 7 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread docmostly/Features/Spaces/MainShellContentView.swift
* fix: open iPad pages in the detail column

* fix: preserve content column navigation

* fix: reconcile iPad navigation transitions

* fix: preserve page tree selection on resize
@greptile-apps
greptile-apps Bot dismissed their stale review September 1, 2026 16:34

Dismissed because a newer commit was pushed; Greptile will re-review the current head.

@Chefski
Chefski merged commit dca2133 into main Sep 1, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant