Conversation
* fix: open iPad pages in the detail column * fix: preserve content column navigation * fix: reconcile iPad navigation transitions
|
| Filename | Overview |
|---|---|
| docmostly/Features/PageReader/PageOpenPresentation.swift | Defines the environment-driven distinction between stack and detail-column page presentation and its cleanup policy. |
| docmostly/Features/PageReader/PageOpenTarget.swift | Routes reusable page links through stack navigation or direct detail selection and applies presentation-aware cleanup. |
| docmostly/Features/PageTree/PageTreeNodeView.swift | Uses direct detail-column selection for regular-width page-tree navigation while retaining stack links in compact layouts. |
| docmostly/Features/Notifications/NotificationListRow.swift | Makes notification page opening presentation-aware while preserving unread-state updates. |
| docmostly/Features/Spaces/MainShellContentView.swift | Extracts the content root view and clears obsolete stack navigation when switching into detail-column mode. |
| docmostly/Features/Spaces/MainShellView.swift | Derives page presentation from the iOS horizontal size class and injects it throughout the split-view hierarchy. |
| docmostlyTests/PageReader/PageOpenPresentationTests.swift | Verifies that stack readers clear selection while detail-column transitions preserve it. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[MainShellView reads horizontal size class] --> B{Compact layout?}
B -->|Yes| C[PageOpenPresentation.stack]
B -->|No| D[PageOpenPresentation.detailColumn]
C --> E[NavigationLink pushes reader]
E --> F[Reader disappearance clears matching selection]
D --> G[Button updates AppState selection]
G --> H[MainShellDetailView displays reader]
H --> I[Reader disappearance preserves selection]
Reviews (1): Last reviewed commit: "Fix iPad page navigation duplication (#4..." | Re-trigger Greptile
There was a problem hiding this comment.
All reported issues were addressed across 7 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
* fix: open iPad pages in the detail column * fix: preserve content column navigation * fix: reconcile iPad navigation transitions * fix: preserve page tree selection on resize
greptile-apps
Bot
dismissed
their stale review
September 1, 2026 16:34
Dismissed because a newer commit was pushed; Greptile will re-review the current head.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes the tested iPad navigation fix from
devtomainfor the next Xcode Cloud release build.Verification completed on the source PR: