Repository navigation
docs: knock out the visual-coverage remainder (framing, hide-adhesion, diagnostics) - #425
Merged
Merged
Conversation
New MIT fixture (tools/fixtures/make-skirt-brim.mjs → test-data/fixtures/ annotations/skirt-brim-model.gcode): a model wrapped by a skirt + brim, so model-bounds differ from whole-job bounds and Skirt/Brim segments exist. Captured (mid-grey presentation, wired into the feature gallery + matrix): - object-aware framing comparison — frame-all vs frame-object (skirt included vs the part framed alone). - setFeatureRoleVisible before/after — frame-all vs adhesion-hidden (skirt/brim shown vs hidden), same framing. - getRenderStats diagnostics in-context — diagnostics-panel (the demo panel reading backend/GPU/geometry/counts/timings beside the render). Harness: frameContent-aware framing (model vs whole-job bounds), a hideRoles param (setFeatureRoleVisible), and diagnostics/transparent-checker recipes. Demo corpus gains the skirt-brim fixture. Honestly deferred with reasons in the matrix: transparent-background capture (headless SwiftShader flattens readback alpha — hardware-validated by AnyBridge), interaction-aware quality + true load-time progressive (motion, not stills), time-scrub (redundant with scrub-sweep), and a few lower-priority polish shots. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears the tracked visual-coverage remainder ahead of the release.
New MIT fixture — a model wrapped by a skirt + brim (
skirt-brim-model.gcode, generated) — so model bounds differ from whole-job bounds and Skirt/Brim segments exist.Captured (mid-grey, in the gallery + matrix):
frame-allvsframe-object.setFeatureRoleVisiblebefore/after —frame-allvsadhesion-hidden(skirt ring shown vs gone, same framing).getRenderStatsdiagnostics in-context —diagnostics-panel.Honestly deferred, with reasons in the matrix (valid dispositions, not silent omissions): transparent-background capture (headless SwiftShader flattens readback alpha — AnyBridge validated correct alpha on a 4070), interaction-aware quality + true load-time progressive (motion, not a still), time-scrub (redundant with the scrub animation), and a few lower-priority polish shots.
Verified: Pages build within budget, 25 media copied, 244 links OK, prettier/eslint clean. Docs/tooling only — no changeset.
🤖 Generated with Claude Code