[Nitro] Remove a redundant namespace qualifier in AgentsMode - #10481
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Restore the namespace qualifier or introduce a type alias to resolve the type unambiguously.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
This PR removes the redundant Input. qualifier from KeyMap.BoardOrientationHint, but the unqualified reference conflicts with the existing KeyMap property and does not compile.
Changes:
- Replaces
Input.KeyMap.BoardOrientationHintwithKeyMap.BoardOrientationHint.
| File | Review |
|---|---|
src/Nitro/CommandLine/src/CommandLine/Tui/Agents/AgentsMode.cs |
The KeyMap property shadows the imported type, causing a critical compile error (3 votes). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
|
✅ Nitro CLI E2E snapshots: no flow recordings changed vs |
Contributor
Patch coverage100.0% of changed lines covered (1/1)
Project coverage: 57.9% (301021/519918 lines) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Input.qualifier fromKeyMap.BoardOrientationHintinAgentsMode. The file already importsChilliCream.Nitro.CommandLine.Tui.Input, so the simple name resolves to the same member. No behavior change.