Repository navigation
Update dev and test packages, including xUnit v3 4.0 and Aspire 13.6 - #10553
Merged
Merged
Conversation
github-actions
Bot
added
🌶️ hot chocolate
🌶️ strawberry shake
🌶️ green donut
🌶️ mocha
labels
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Resolve the CookieCrumble xUnit version mismatch and update the k6 benchmark dependency overrides.
2 open findings
What changed in this PR
Updates development/test dependencies, migrates tests to xUnit 4 with MTP v2, and upgrades Aspire examples and benchmarks.
Changes:
- Refreshes testing, tooling, analyzer, database, and container packages.
- Updates Aspire AppHosts to 13.6.1 with CLI bundle configuration.
- Preserves CookieCrumble’s xUnit 3 package floor.
| File | Reviewed changes |
|---|---|
src/StrawberryShake/Tooling/test/Directory.Test.props |
Migrates test runner packages. |
src/StrawberryShake/CodeGeneration/test/Directory.Test.props |
Migrates test runner packages. |
src/StrawberryShake/Client/test/Directory.Test.props |
Migrates test runner packages. |
src/Nitro/Common/test/Directory.Test.props |
Migrates test runner packages. |
src/Nitro/CommandLine/test/Directory.Test.props |
Migrates test runner packages. |
src/Mocha/test/Directory.Test.props |
Migrates test runner packages. |
src/Mocha/examples/PostgresTransport/PostgresTransport.AppHost/PostgresTransport.AppHost.csproj |
Updates Aspire SDK and enables the CLI bundle. |
src/Mocha/examples/PostgresTransport/Directory.Packages.props |
Updates Aspire and observability packages. |
src/Mocha/examples/PostgresTransport/aspire.config.json |
Adds Aspire CLI configuration. |
src/Mocha/examples/Demo/Directory.Packages.props |
Updates Aspire and supporting packages. |
src/Mocha/examples/Demo/Demo.AppHost/Demo.AppHost.csproj |
Updates Aspire SDK and enables the CLI bundle. |
src/Mocha/examples/Demo/Demo.AppHost/aspire.config.json |
Adds Aspire CLI configuration. |
src/Mocha/examples/AzureServiceBusTransport/Directory.Packages.props |
Updates Aspire, Nitro, and observability packages. |
src/Mocha/examples/AzureServiceBusTransport/AzureServiceBusTransport.AppHost/AzureServiceBusTransport.AppHost.csproj |
Updates Aspire SDK and enables the CLI bundle. |
src/Mocha/examples/AzureServiceBusTransport/aspire.config.json |
Normalizes Aspire CLI configuration. |
src/Mocha/benchmarks/Directory.Packages.props |
Updates benchmark analyzers. |
src/HotChocolate/Utilities/test/Directory.Test.props |
Migrates test runner packages. |
src/HotChocolate/Spatial/test/Directory.Test.props |
Migrates test runner packages. |
src/HotChocolate/Raven/test/Directory.Test.props |
Migrates test runner packages. |
src/HotChocolate/Primitives/test/Directory.Test.props |
Migrates test runner packages. |
src/HotChocolate/PersistedOperations/test/Directory.Test.props |
Migrates test runner packages. |
src/HotChocolate/Mutable/test/Directory.Test.props |
Migrates test runner packages. |
src/HotChocolate/MongoDb/test/Directory.Test.props |
Migrates test runner packages. |
src/HotChocolate/Marten/test/Directory.Test.props |
Migrates test runner packages. |
src/HotChocolate/Language/test/Directory.Test.props |
Migrates test runner packages. |
src/HotChocolate/Json/test/Directory.Test.props |
Migrates test runner packages. |
src/HotChocolate/Fusion/test/Directory.Test.props |
Migrates test runner packages. |
src/HotChocolate/Diagnostics/test/Directory.Test.props |
Migrates test runner packages. |
src/HotChocolate/Data/test/Directory.Test.props |
Migrates test runner packages. |
src/HotChocolate/CostAnalysis/test/Directory.Test.props |
Migrates test runner packages. |
src/HotChocolate/Core/test/Directory.Test.props |
Migrates test runner packages. |
src/HotChocolate/Caching/test/Directory.Test.props |
Migrates test runner packages. |
src/HotChocolate/AzureFunctions/test/Directory.Test.props |
Migrates test runner packages. |
src/HotChocolate/AspNetCore/test/Directory.Test.props |
Migrates test runner packages. |
src/HotChocolate/AspNetCore/benchmarks/k6/Catalog.AppHost/eShop.Catalog.AppHost.csproj |
Updates Aspire SDK and enables the CLI bundle. Moderate finding (2 votes): referenced Catalog.ServiceDefaults overrides still pin older resilience, service-discovery, and OpenTelemetry packages. |
src/HotChocolate/AspNetCore/benchmarks/k6/Catalog.AppHost/aspire.config.json |
Adds Aspire CLI configuration. |
src/HotChocolate/ApolloFederation/test/Directory.Test.props |
Migrates test runner packages. |
src/HotChocolate/Adapters/test/Directory.Test.props |
Migrates test runner packages. |
src/GreenDonut/test/Directory.Test.props |
Migrates test runner packages. |
src/Directory.Packages.props |
Updates central dependency versions. Moderate finding (1 vote): explicit k6 Catalog.ServiceDefaults overrides prevent the intended package updates. |
src/CookieCrumble/test/CookieCrumble.Tests/CookieCrumble.Tests.csproj |
Keeps CookieCrumble tests on xUnit 3.2.2. |
src/CookieCrumble/src/CookieCrumble.Xunit3/CookieCrumble.Xunit3.csproj |
Keeps adapter references on xUnit 3.2.2. Critical finding (1 vote): the adapter is compiled against xUnit 3 while consumers use the xUnit 4 runner. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
glen-84
force-pushed
the
gai/update-dev-and-test-packages
branch
from
October 15, 2026 18:41
c5cca44 to
7984516
Compare
glen-84
changed the title
Contributor
|
✅ Nitro CLI E2E snapshots: no flow recordings changed vs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Microsoft.Data.SqlClient7.1.1,CliWrap3.10.5, andMicrosoft.Extensions.TimeProvider.Testing10.10. The k6 benchmark and the Mocha examples move to Aspire 13.6.1 (AppHost SDK included), OpenTelemetry 1.19,Microsoft.Extensions.Http.ResilienceandServiceDiscovery10.10, andChilliCream.Nitro*16.6.8. Packages that reach consumers are unchanged.xunit.v3.mtp-v24.0.1,TrxReport2.5.1,CodeCoverage18.8.0). The test props follow the xUnit v3 4.0.1 template default, withoutUseMicrosoftTestingPlatformRunner:dotnet testtakes the same options as before, anddotnet runon a test project takes xUnit's own (-class,-method).CookieCrumble.Xunit3keeps its xUnit v3 3.2.2 floor throughVersionOverride, andCookieCrumble.Testsstays on xUnit v3 3.2.2, so CookieCrumble is still tested on what it ships against.CodeCoveragestops at 18.8.0 because later versions needSystem.IO.Pipelines10 on net8.0, which conflicts with the direct reference in the Fusion packaging tests.AspireUseCliBundle), which Aspire recommends and which clears ASPIRE010, and theaspire.config.jsonfiles the CLI writes are committed.Test plan
src/All.slnxrestored with--force-evaluateand built for all target frameworks: no errors and no new warnings, so Roslynator 5 andxunit.analyzers2.1 report nothing new.Mocha.slnx, the Demo example (also as the net10.0-only build withDOTNET_LOCAL_DEV_SINGLE_TARGET_FRAMEWORK=1), and the AzureServiceBusTransport AppHost build. The AppHost needs-p:EnforceCodeStyleInBuild=false, because of IDE0005 and IDE1006 errors in its services that already exist onmain.dotnet test --filter-classand--filter-methodwork with the new test props.