Skip to content

Broken for python >= 3.10 #10

Description

@pejobo

I know the plugin is currently broken due to changes on the subscene website (see #9 and #8) what is really sad.

But if this is fixed the plugin is also currently broken for python 3.10 or newer because the types Mappings and MutableMapping now only sit in package collections.abc, not in collections.

The fix is small, just use these snippet for importin:

try:
    from collections import Mapping
except ImportError:
    from collections.abc import Mapping

(for file lib/html5lib/_trie/_base.py)

try:
    from collections import MutableMapping
except ImportError:
    from collections.abc import MutableMapping

(for file lib/html5lib/treebuilders/dom.py)

Maybe you can incorporate these changes when updating the plugin.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions