[pulpdrew]

Summary

This PR ensures the height of the RHS kebab menu on the source select component matches the height of the source select input.

Screenshots or video

Before:

After:

How to test on Vercel preview

This can be tested on the preview, wherever the source select is available.

References

• Linear Issue:
• Related PRs:

[changeset-bot]

🦋 Changeset detected

Latest commit: e9b456f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@hyperdx/app	Patch
@hyperdx/api	Patch
@hyperdx/otel-collector	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
hyperdx-oss	Ready	Preview, Comment	Jun 4, 2026 6:14pm
hyperdx-storybook	Ready	Preview, Comment	Jun 4, 2026 6:14pm

[github-actions]

🔵 Tier 2 — Low Risk

Small, isolated change with no API route or data model modifications.

Why this tier:

• Standard feature/fix — introduces new logic or modifies core functionality

Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns.
SLA: Resolve within 4 business hours.

Stats

• Production files changed: 2
• Production lines changed: 14
• Branch: drew/fix-source-select-size
• Author: pulpdrew

To override this classification, remove the review/tier-2 label and apply a different review/tier-* label. Manual overrides are preserved on subsequent pushes.

[github-actions]

Deep Review

✅ No critical issues found.

This is a focused, low-risk cosmetic fix. The kebab ActionIcon now derives its input-* size from the adjacent Select's size (default 'sm') instead of a hardcoded input-xs + fixed 30px square, so the kebab height tracks the input height. When size is omitted, the menu's 'sm' default matches Mantine's Select default, and every current SourceSelectControlled caller passes only "xs" or nothing — so no height mismatch is reachable from the current call sites. No correctness, security, or contract issues.

🔵 P3 nitpicks (2)

• packages/app/src/components/DBTableSelect.tsx:72 — SourceManagementMenu is rendered without size, while its sibling Select receives size={size}; this diff also shifts DBTableSelect's kebab default from input-xs to input-sm. No caller passes a non-sm size today, so heights stay aligned, but the inconsistency is latent.
  • Fix: Thread size={size} into the SourceManagementMenu call in DBTableSelect so both surfaces share one Mantine size.
  • _{ce-maintainability-reviewer}
• packages/app/src/components/SourceSelect.tsx:49 — the new size?: string prop is untyped against Mantine's size union, so `input-${size}` can interpolate to an invalid token (e.g. input-42) with no compile-time guard; this mirrors the pre-existing loose typing on the parent component.
  • Fix: Type the prop as MantineSize (or SelectProps['size']) on SourceManagementMenuProps.
  • _{ce-kieran-typescript-reviewer, ce-maintainability-reviewer, ce-project-standards-reviewer}

---

Reviewers (5): ce-correctness-reviewer, ce-kieran-typescript-reviewer, ce-maintainability-reviewer, ce-testing-reviewer, ce-project-standards-reviewer.

Testing gaps: No test asserts the kebab renders `input-${size}` for a given size, and the codebase does not unit-test CSS height — acceptable for a cosmetic fix, but the input-xs → input-sm default shift is unguarded.

[github-actions]

E2E Test Results

✅ All tests passed • 195 passed • 3 skipped • 1293s

Status	Count
✅ Passed	195
❌ Failed	0
⚠️ Flaky	4
⏭️ Skipped	3

Tests ran across 4 shards in parallel.

View full report →