Skip to content

fix: Fix height of source select RHS menu #2419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 2 commits into from
Jun 4, 2026
Merged

fix: Fix height of source select RHS menu #2419

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0841636
fix: Fix height of source select RHS menu
pulpdrew Jun 4, 2026
e9b456f
Merge branch 'main' into drew/fix-source-select-size
kodiakhq[bot] Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/smooth-turkeys-dream.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@hyperdx/app": patch
---

fix: Fix height of source select RHS menu
5 changes: 4 additions & 1 deletion packages/app/src/components/SourceSelect.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ interface SourceManagementMenuProps {
*/
onManageSources?: () => void;
onCreate?: () => void;
size?: string;
}

/**
Expand All @@ -63,6 +64,7 @@ interface SourceManagementMenuProps {
*/
export const SourceManagementMenu = ({
hasSelection,
size = 'sm',
onSchemaPreview,
isSchemaPreviewEnabled = true,
onEdit,
Expand Down Expand Up @@ -133,7 +135,7 @@ export const SourceManagementMenu = ({
<ActionIcon
variant="subtle"
color="gray"
size="input-xs"
size={`input-${size}`}
className={styles.sourceMenuButton}
data-testid="source-actions-menu"
aria-label="Source actions"
Expand Down Expand Up @@ -236,6 +238,7 @@ function SourceSelectControlledComponent({
{hasMenu && (
<SourceManagementMenu
hasSelection={hasSelection}
size={size}
onSchemaPreview={onSchemaPreview}
isSchemaPreviewEnabled={isSchemaPreviewEnabled}
onEdit={onEdit}
Expand Down
9 changes: 4 additions & 5 deletions packages/app/styles/SourceSelectControlled.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,14 +46,13 @@
border-bottom-left-radius: var(--mantine-radius-default);
}

/* Square only the left edge of the kebab. Fixed 30px height matches the
* input chip; -1px margin overlaps the input's right edge so the shared
* border is one pixel wide, not two. */
/* Square only the left edge of the kebab. The ActionIcon's `input-*`
* size (driven by the adjacent Select's `size`) makes it square and
* matches the input chip's height; -1px margin overlaps the input's
* right edge so the shared border is one pixel wide, not two. */
.sourceMenuButton {
--ai-radius: 0;

width: 30px;
height: 30px;
margin-left: -1px;
background-color: var(--color-bg-field-addon);
border: 1px solid var(--input-bd, var(--color-border));
Expand Down
Loading