Repository navigation
fix(Grid): respect rowStart when copying selected columns - #1271
Open
fallintoplace wants to merge 3 commits into
Open
fallintoplace wants to merge 3 commits into
fallintoplace wants to merge 3 commits into
Conversation
🦋 Changeset detectedLatest commit: 777df0d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Collaborator
|
@fallintoplace please check the formatting, |
Contributor
Chromatic Storybook
Built from commit: Statuses as of the end of the run. The build link shows the live review state. |
Contributor
Author
|
Thanks, it was already fixed. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
rowStart.rowStartto the copy helper and keep selected column indexes zero-based.rowStart={100}, copying three rows uses100,101, and102.Links and tickets
Good to know
Checklist
Contribution
buildandbuild-storybookwork locallyAccessibility
aria-labelScreenshots
No visual changes.
Note
Low Risk
Localized clipboard/copy helper behavior with tests; no API or visual changes beyond fixing incorrect copied row/column indices.
Overview
Fixes Grid clipboard copy when the visible window uses a non-zero
rowStart(e.g. paged or virtualized data). Column selections were rendered from row 0 instead of the current offset.The default copy path in
Gridnow passesrowStartintocopyGridElements, which renamespageStarttorowStartand usesrowStart + indexwhen building rows for a columns selection. For rows selection, column indices stay 0-based (0 … columnCount - 1) instead of incorrectly offsetting columns by the row window.Tests cover integration (Ctrl+C forwards
rowStart) and copy helper behavior for column and row selections withrowStart: 100. Patch changeset for@clickhouse/click-ui.Reviewed by Cursor Bugbot for commit 6f6b15a. Bugbot is set up for automated code reviews on this repo. Configure here.