Repository navigation
feat(Alert): add maxHeight with show more toggle #1279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fneves
wants to merge
9
commits into
main
Choose a base branch
from
fn/cui-336-alert-max-height-0fd0
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
081e3a3
feat(Alert): add maxHeight with show more toggle
cursoragent c8be6c0
docs(Alert): add max height stories
cursoragent 07bb24a
test(Alert): add max height visual specs
cursoragent ef7572d
chore: add changeset for Alert maxHeight
cursoragent 182d160
docs(Alert): spy on onExpandedChange in play stories
cursoragent 9d3d9ce
fix(Alert): disconnect height observers when the alert is dismissed
cursoragent 68815ed
fix(Alert): let the title wrap in maxHeight mode instead of truncatin…
cursoragent ebca59d
fix(Alert): fill the container when maxHeight is expanded
cursoragent ca3b277
test(Alert): update expanded maxHeight snapshots
cursoragent File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@clickhouse/click-ui': minor | ||
| --- | ||
|
|
||
| `Alert` accepts `maxHeight` to cap its collapsed height and show a Show more / Show less toggle when the text overflows. Expanded, the alert fills its container and the text scrolls inside it. Visual: unchanged unless `maxHeight` is set. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expanding drops the height cap
High Severity
Expanding applies
alert_expanded, which setsmax-heighttonone. If the parent has no definite height,height: 100%andflex: 1 1 autodo nothing, so the alert grows with the text. Overflow then measures as false, the Show less toggle unmounts, and the expanded layout cannot be collapsed.Additional Locations (1)
src/components/Alert/Alert.tsx#L199-L200Reviewed by Cursor Bugbot for commit ca3b277. Configure here.