Repository navigation
Ship backfill rows to the batcher in chunks - #271
Merged
Merged
Conversation
serprex
force-pushed
the
split/ack-allocator
branch
2 times, most recently
from
October 22, 2026 20:38
3f811d2 to
d1b7c2f
Compare
serprex
force-pushed
the
split/row-chunks
branch
from
October 23, 2026 01:36
4f8fac7 to
af2d1a4
Compare
Member
Author
|
Parent
16,384×64 reruns at 11 samples: 238–244 ms, noise. cargo bench --bench wal_replay -- --rows 1 --transactions 262144 --columns 8 --repeats 7 |
serprex
force-pushed
the
split/row-chunks
branch
from
October 23, 2026 01:55
af2d1a4 to
568d6b6
Compare
WAL replay sent rows to batcher one at a time, adding channel overhead for every row. Bootstrap already grouped rows into chunks. Share bootstrap row buffer with WAL replay and allow chunks to span transactions. Register transactions before sending rows, then report row counts afterward so acknowledgments cannot arrive too early. Flush buffered rows at size limits, input boundaries, idle, completion, and errors. Send rows holding detoast memory permits immediately so buffered memory cannot block later allocations. Keep failed transactions incomplete so acknowledgments cannot advance past them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
serprex
force-pushed
the
split/row-chunks
branch
from
October 23, 2026 02:49
568d6b6 to
02947c2
Compare
harshil-goel
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WAL replay sent rows to batcher one at a time, adding channel overhead
for every row. Bootstrap already grouped rows into chunks.
Share bootstrap row buffer with WAL replay and allow chunks to span
transactions. Register transactions before sending rows, then report
row counts afterward so acknowledgments cannot arrive too early.
Flush buffered rows at size limits, input boundaries, idle, completion,
and errors. Send rows holding detoast memory permits immediately so
buffered memory cannot block later allocations. Keep failed transactions
incomplete so acknowledgments cannot advance past them.
Depends on #265.
Validation:
cargo fmt --all -- --check,cargo clippy --workspace --all-targets --locked -- -D warnings,RUSTDOCFLAGS=-D warnings cargo doc --no-deps --lib --bins, fullcargo nextest run --workspace --all-targets --lockedagainst PG 17.🤖 Generated with Claude Code