Repository navigation
build(core): bump bundled axios and form-data past known CVEs - #115
Conversation
The Rollup build inlines axios, follow-redirects and form-data into the core dist, using the versions pinned in pnpm-lock.yaml. The lockfile still held axios 1.4.0, follow-redirects 1.15.2 and form-data 4.0.4, so the published bundle shipped vulnerable copies that npm audit cannot see. Raise the minimum ranges to axios ^1.21.0 and form-data ^4.0.6 and refresh the lockfile, which now resolves follow-redirects 1.16.0. nx's axios is deduplicated to the same 1.21.0. Closes #114 Closes COD-4066 Co-Authored-By: Claude <noreply@anthropic.com>
Merging this PR will degrade performance by 15.85%3 warnings, 1 note
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing Footnotes
|
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryUpdates the dependencies bundled into
Reviews (1) · Last reviewed commit: "build(core): bump bundled axios and form..." · Reviewed by Greptile |
Bump axios to ^1.21.0 and form-data to ^4.0.6 in
@codspeed/coreand refresh the lockfile.The Rollup build bundles these dependencies into
dist/from the versions pinned inpnpm-lock.yaml, which still held axios 1.4.0, follow-redirects 1.15.2 and form-data 4.0.4. The declared ranges already allowed fixed releases, sonpm auditreported nothing for users while the inlined copies stayed vulnerable (axios advisories fixed in 1.16.0, follow-redirects GHSA-r4q5-vmmm-2653, form-data GHSA-hmw2-7cc7-3qxx).The lockfile now resolves axios 1.21.0, follow-redirects 1.16.0 and form-data 4.0.6. The rebuilt
dist/index.cjs.jsreports axiosVERSION = "1.21.0".nx's axios is deduplicated to the same version.Marking these packages
externalin Rollup would also fix it, but it changes how the package is built, which is a larger change than this fix needs. A republish of core and the plugins is needed for users to pick up the fix.Closes #114
Closes COD-4066