Skip to content

samply-codspeed: bump submodule to not loop on corrupted jit dump - #599

Merged
GuillaumeLagrange merged 1 commit into
mainfrom
cod-4043-jitdump-malformed-record
Oct 30, 2026
Merged

GuillaumeLagrange merged 1 commit into
mainfrom
cod-4043-jitdump-malformed-record

Conversation

@GuillaumeLagrange

Copy link
Copy Markdown
Contributor

Related: CodSpeedHQ/samply-codspeed#14

Closes COD-4043

@greptile-apps

greptile-apps Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] No confirmed issue blocks merging.

Summary

Updates crates/samply-codspeed to 2eaaf6e72aba2cb1c0c5f6257969908b617a7bc4, intended to prevent looping on corrupted JIT dumps.

  • Wall-time profiling no longer loops on corrupted JIT dumps.

Reviews (2) · Last reviewed commit: "samply-codspeed: bump submodule to not l..." · Reviewed by Greptile

@codspeed

codspeed Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

2 warnings

⚠️ Walltime results may be unreliable

Some benchmarks used the Walltime instrument outside CodSpeed Macro Runners, which can make the results inconsistent.

Learn more about Macro Runners

See affected benchmarks

⚠️ 8 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

✅ 41 untouched benchmarks
⏩ 6 skipped benchmarks1


Comparing cod-4043-jitdump-malformed-record (6c5b646) with main (d14d95d)

Open in CodSpeed

Footnotes

  1. 6 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@not-matthias not-matthias left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, don't forget to update the submodule ref to exclude the stack cache changes

@GuillaumeLagrange
GuillaumeLagrange force-pushed the cod-4043-jitdump-malformed-record branch from fb0d8c6 to 6c5b646 Compare October 30, 2026 13:39
@GuillaumeLagrange
GuillaumeLagrange merged commit 6c5b646 into main Oct 30, 2026
66 checks passed
@GuillaumeLagrange
GuillaumeLagrange deleted the cod-4043-jitdump-malformed-record branch October 30, 2026 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants