Skip to content

chore: bump pinned valgrind-codspeed to 3.26.0-0codspeed12 - #604

Merged
adriencaccia merged 1 commit into
mainfrom
cod-4094-release-valgrind-codspeed-and-runner
Nov 3, 2026
Merged

adriencaccia merged 1 commit into
mainfrom
cod-4094-release-valgrind-codspeed-and-runner

Conversation

@adriencaccia

Copy link
Copy Markdown
Member

Points the runner at valgrind-codspeed 3.26.0-0codspeed12, which stops simulated arm64 programs from dying with SIGILL when they read a previously unsupported CPU ID register or TPIDRRO_EL0 (CodSpeedHQ/valgrind-codspeed#59). It also ships the opt-in --deterministic-rng flag from 0codspeed11, which the runner does not pass yet.

The 6 hashes match the release's asset digests.

Refs COD-4094, which stays open for the runner v5.6.2 release this unblocks.

The new package decodes arm64 reads of every EL0-visible CPU ID register
and of TPIDRRO_EL0, which used to stop simulated programs with SIGILL.
It also ships the opt-in --deterministic-rng flag from 0codspeed11.

Refs COD-4094

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@greptile-apps

greptile-apps Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] This PR appears safe to merge; no actionable issues were found.

Summary

Updates the pinned Valgrind build from 3.26.0-0codspeed10 to 3.26.0-0codspeed12.

  • Linux Valgrind setup now uses release iteration 12.

Reviews (1) · Last reviewed commit: "chore: bump pinned valgrind-codspeed to ..." · Reviewed by Greptile

@codspeed

codspeed Bot commented Nov 3, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 12.87%

2 warnings

⚠️ Walltime results may be unreliable

Some benchmarks used the Walltime instrument outside CodSpeed Macro Runners, which can make the results inconsistent.

Learn more about Macro Runners

See affected benchmarks

⚠️ 8 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

❌ 1 regressed benchmark
✅ 40 untouched benchmarks
⏩ 6 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Walltime memtrack track tar 8.2 s 9.4 s -12.87%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing cod-4094-release-valgrind-codspeed-and-runner (8607d16) with main (ea54386)

Open in CodSpeed

Footnotes

  1. 6 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@adriencaccia
adriencaccia merged commit 1d4fed4 into main Nov 3, 2026
65 of 66 checks passed
@adriencaccia
adriencaccia deleted the cod-4094-release-valgrind-codspeed-and-runner branch November 3, 2026 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant