Repository navigation
fix: bump go-runner to 1.4.0 - #605
Conversation
The new go-runner counts every timed segment of a b.Loop() iteration, so benchmarks that stop and restart the timer inside an iteration report all their timed work. It also drops the value of unsupported go test flags along with the flag, so `-p 1` no longer fails the run. Refs COD-4097 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
[Medium impact] The PR appears safe to merge; no actionable defects were found. SummaryUpdates the default Go runner from 1.3.0 to 1.4.0.
No actionable issues were found. Tests were not run, and the published release asset was not independently verified. Reviews (1) · Last reviewed commit: "fix: bump go-runner to 1.4.0" · Reviewed by Greptile |
Merging this PR will not alter performance2 warnings
Comparing Footnotes
|
Points the runner at codspeed-go 1.4.0:
b.Loop()benchmarks that stop and restart the timer inside an iteration now report all their timed work (CodSpeedHQ/codspeed-go#69), and unsupportedgo testflags are dropped together with their value, sogo test -p 1 ./... -bench .no longer fails (CodSpeedHQ/codspeed-go#67).The installer hash matches the release asset digest.
Refs COD-4097, which stays open for the runner v5.6.3 release this unblocks.