Skip to content

fix: bump go-runner to 1.4.0 - #605

Merged
adriencaccia merged 1 commit into
mainfrom
cod-4097-release-codspeed-go-and-runner
Nov 3, 2026
Merged

adriencaccia merged 1 commit into
mainfrom
cod-4097-release-codspeed-go-and-runner

Conversation

@adriencaccia

Copy link
Copy Markdown
Member

Points the runner at codspeed-go 1.4.0: b.Loop() benchmarks that stop and restart the timer inside an iteration now report all their timed work (CodSpeedHQ/codspeed-go#69), and unsupported go test flags are dropped together with their value, so go test -p 1 ./... -bench . no longer fails (CodSpeedHQ/codspeed-go#67).

The installer hash matches the release asset digest.

Refs COD-4097, which stays open for the runner v5.6.3 release this unblocks.

The new go-runner counts every timed segment of a b.Loop() iteration,
so benchmarks that stop and restart the timer inside an iteration
report all their timed work. It also drops the value of unsupported
go test flags along with the flag, so `-p 1` no longer fails the run.

Refs COD-4097

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@greptile-apps

greptile-apps Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable defects were found.

Summary

Updates the default Go runner from 1.3.0 to 1.4.0.

  • Go benchmark runs use runner 1.4.0 by default.

No actionable issues were found. Tests were not run, and the published release asset was not independently verified.

Reviews (1) · Last reviewed commit: "fix: bump go-runner to 1.4.0" · Reviewed by Greptile

@codspeed

codspeed Bot commented Nov 3, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

2 warnings

⚠️ Walltime results may be unreliable

Some benchmarks used the Walltime instrument outside CodSpeed Macro Runners, which can make the results inconsistent.

Learn more about Macro Runners

See affected benchmarks

⚠️ 9 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

✅ 41 untouched benchmarks
⏩ 6 skipped benchmarks1


Comparing cod-4097-release-codspeed-go-and-runner (99cb6c5) with main (415d540)

Open in CodSpeed

Footnotes

  1. 6 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@adriencaccia
adriencaccia merged commit 2741c31 into main Nov 3, 2026
66 checks passed
@adriencaccia
adriencaccia deleted the cod-4097-release-codspeed-go-and-runner branch November 3, 2026 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant