Repository navigation
feat(linux): mark truncated and failed sample stacks - #13
Open
not-matthias wants to merge 1 commit into
Open
not-matthias wants to merge 1 commit into
not-matthias wants to merge 1 commit into
Conversation
not-matthias
force-pushed
the
cod-3911-mark-truncated-nodes-in-samply
branch
from
October 23, 2026 14:57
9a55647 to
4e769c5
Compare
not-matthias
marked this pull request as ready for review
October 23, 2026 14:59
GuillaumeLagrange
approved these changes
Oct 27, 2026
Comment on lines
+42
to
+43
| Truncated, | ||
| UnwindFailed, |
There was a problem hiding this comment.
We could have small docstrings to explain what's the difference between these two
| if common == dwarf_len { | ||
| stack.extend_from_slice(&fp_user_frames[common..]); | ||
| } else if fp_user_frames.len() > dwarf_len && common >= 1 { | ||
| if fp_user_frames.len() > dwarf_len && (common == dwarf_len || common >= 1) { |
There was a problem hiding this comment.
Same remark as in the backend PR: this is really opinionated and should be marked as such.
We could also use a full text description of why this condition IMO.
Expose incomplete DWARF stacks as synthetic root labels in Firefox profiles instead of silently dropping the truncation sentinel. Distinguish capture exhaustion from other unwind errors, and attach markers after frame-pointer recovery, root trimming, and recursion folding. Keep the existing cache validation policy. Refs COD-3911
not-matthias
force-pushed
the
cod-3911-mark-truncated-nodes-in-samply
branch
from
October 30, 2026 13:54
4e769c5 to
f284242
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR: Make incomplete Linux sample stacks visible as
[truncated]or[unwind_failed]synthetic root frames instead of silently dropping the diagnostic.[truncated]. Verified in the Firefox Profiler call tree and flame graph.Refs COD-3911