Repository navigation
Bump dtolnay/rust-toolchain from e2a55d2ffb04f378e9626c28d38b36d230d1e12f to 683b588c487a69d01f6c6ddf40f036ff682cc2c8 - #131
Conversation
computerbox124
left a comment
There was a problem hiding this comment.
Code review: 1 finding, inline. The dtolnay/rust-toolchain pin overlaps #128, which pins a different SHA on the same lines. Rebase this after #128 merges.
Generated by Claude Code
| with: | ||
| persist-credentials: false | ||
| - uses: dtolnay/rust-toolchain@7e38f4b43b4db5c8dd498af069a4f6196df1d067 # v1 | ||
| - uses: dtolnay/rust-toolchain@683b588c487a69d01f6c6ddf40f036ff682cc2c8 # v1 |
There was a problem hiding this comment.
Overlaps with #128.
#128 pins dtolnay/rust-toolchain to e2a55d2f… on the same five lines (ci.yml ×3, release.yml, windows-nsis-smoke.yml). This PR pins 683b588c…, the next commit ("Add 1.99.1 patch release"). Both include the input-handling fix from dtolnay/rust-toolchain#187. Whichever PR merges second conflicts, and a careless resolution could keep the older pin.
Since #128 is meant to merge first, the simplest path is to let Dependabot rebase this PR after #128 lands so the newer pin wins, or to drop the toolchain bump from #128.
Generated by Claude Code
Bumps [dtolnay/rust-toolchain](https://github.com/dtolnay/rust-toolchain) from e2a55d2ffb04f378e9626c28d38b36d230d1e12f to 683b588c487a69d01f6c6ddf40f036ff682cc2c8. - [Release notes](https://github.com/dtolnay/rust-toolchain/releases) - [Commits](dtolnay/rust-toolchain@e2a55d2...683b588) --- updated-dependencies: - dependency-name: dtolnay/rust-toolchain dependency-version: 683b588c487a69d01f6c6ddf40f036ff682cc2c8 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
13d08eb to
b8c9dd7
Compare
Bumps dtolnay/rust-toolchain from e2a55d2ffb04f378e9626c28d38b36d230d1e12f to 683b588c487a69d01f6c6ddf40f036ff682cc2c8.
Commits
683b588Add 1.99.1 patch releaseNeed help on this PR? Tag
@codesmith-botwith what you need.