Skip to content

Bump dtolnay/rust-toolchain from e2a55d2ffb04f378e9626c28d38b36d230d1e12f to 683b588c487a69d01f6c6ddf40f036ff682cc2c8 - #131

Open
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/github_actions/dtolnay/rust-toolchain-683b588c487a69d01f6c6ddf40f036ff682cc2c8
Open

dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/github_actions/dtolnay/rust-toolchain-683b588c487a69d01f6c6ddf40f036ff682cc2c8

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Bumps dtolnay/rust-toolchain from e2a55d2ffb04f378e9626c28d38b36d230d1e12f to 683b588c487a69d01f6c6ddf40f036ff682cc2c8.

Commits


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@dependabot dependabot Bot added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Oct 16, 2026

@computerbox124 computerbox124 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review: 1 finding, inline. The dtolnay/rust-toolchain pin overlaps #128, which pins a different SHA on the same lines. Rebase this after #128 merges.


Generated by Claude Code

Comment thread .github/workflows/ci.yml
with:
persist-credentials: false
- uses: dtolnay/rust-toolchain@7e38f4b43b4db5c8dd498af069a4f6196df1d067 # v1
- uses: dtolnay/rust-toolchain@683b588c487a69d01f6c6ddf40f036ff682cc2c8 # v1

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overlaps with #128.

#128 pins dtolnay/rust-toolchain to e2a55d2f… on the same five lines (ci.yml ×3, release.yml, windows-nsis-smoke.yml). This PR pins 683b588c…, the next commit ("Add 1.99.1 patch release"). Both include the input-handling fix from dtolnay/rust-toolchain#187. Whichever PR merges second conflicts, and a careless resolution could keep the older pin.

Since #128 is meant to merge first, the simplest path is to let Dependabot rebase this PR after #128 lands so the newer pin wins, or to drop the toolchain bump from #128.


Generated by Claude Code

Bumps [dtolnay/rust-toolchain](https://github.com/dtolnay/rust-toolchain) from e2a55d2ffb04f378e9626c28d38b36d230d1e12f to 683b588c487a69d01f6c6ddf40f036ff682cc2c8.
- [Release notes](https://github.com/dtolnay/rust-toolchain/releases)
- [Commits](dtolnay/rust-toolchain@e2a55d2...683b588)

---
updated-dependencies:
- dependency-name: dtolnay/rust-toolchain
  dependency-version: 683b588c487a69d01f6c6ddf40f036ff682cc2c8
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot changed the title Bump dtolnay/rust-toolchain from 7e38f4b43b4db5c8dd498af069a4f6196df1d067 to 683b588c487a69d01f6c6ddf40f036ff682cc2c8 Bump dtolnay/rust-toolchain from e2a55d2ffb04f378e9626c28d38b36d230d1e12f to 683b588c487a69d01f6c6ddf40f036ff682cc2c8 Oct 18, 2026
@dependabot
dependabot Bot force-pushed the dependabot/github_actions/dtolnay/rust-toolchain-683b588c487a69d01f6c6ddf40f036ff682cc2c8 branch from 13d08eb to b8c9dd7 Compare October 18, 2026 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant