Skip to content

End and reap a local shell when its tab closes, and drop the unused os and process plugins #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sadykhzadeh wants to merge 3 commits into
base: main
Choose a base branch
from
Open

End and reap a local shell when its tab closes, and drop the unused os and process plugins #154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
adb1b79
End and reap a local shell when its tab closes, and drop the unused o…
Sadykhzadeh Oct 16, 2026
524778f
Give a closed tab's shell time to exit, and end it off the map lock
Sadykhzadeh Oct 16, 2026
2fa9d19
Send a closed tab's shell SIGHUP directly
Sadykhzadeh Oct 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 1 addition & 65 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 5 additions & 2 deletions desktop/src-tauri/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,7 @@ clavyn-core = { path = "../../core" }
tauri = { version = "2", features = [] }
tauri-plugin-shell = "2"
tauri-plugin-dialog = "2"
tauri-plugin-os = "2"
tauri-plugin-updater = "2"
tauri-plugin-process = "2"
tauri-plugin-single-instance = "2"
serde = { workspace = true }
serde_json = { workspace = true }
Expand All @@ -41,6 +39,11 @@ tauri = { version = "2", features = ["test"] }
# the known hosts store takes; the workspace pin keeps it the same russh.
russh = { workspace = true }

[target.'cfg(unix)'.dependencies]
# Sends a closed tab's shell SIGHUP directly; already in the tree through
# portable-pty and tokio.
libc = "0.2"

[target.'cfg(target_os = "linux")'.dependencies]
# Resolves the D-Bus session address before the single-instance plugin does,
# because the plugin resolves it with `unwrap` and `panic = "abort"` turns that
Expand Down
3 changes: 1 addition & 2 deletions desktop/src-tauri/capabilities/default.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
"windows": ["main"],
"permissions": [
"core:default",
"shell:allow-open",
"os:default"
"shell:allow-open"
]
}
2 changes: 1 addition & 1 deletion desktop/src-tauri/src/commands.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -766,7 +766,7 @@ pub async fn create_local_terminal(
let terminal = LocalTerminal {
writer,
master,
child,
child: crate::state::LocalShell::new(child),
owns_session_id: owns_session_id.clone(),
};
let refused = {
Expand Down
2 changes: 0 additions & 2 deletions desktop/src-tauri/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,8 +121,6 @@ fn main() {
builder
.plugin(tauri_plugin_shell::init())
.plugin(tauri_plugin_dialog::init())
.plugin(tauri_plugin_os::init())
.plugin(tauri_plugin_process::init())
.plugin(tauri_plugin_updater::Builder::new().build())
.setup(|app| {
// State lives in the non-roaming directory, so a roaming profile
Expand Down
Loading
Loading