Repository navigation
Suppress the updater's zip extraction advisories with a review date - #186
Open
Sadykhzadeh wants to merge 1 commit into
Open
Sadykhzadeh wants to merge 1 commit into
Sadykhzadeh wants to merge 1 commit into
Conversation
… review date tauri-plugin-updater 2.13 and 2.14 require zip 4, so the 9.x fix cannot be taken, and the advisories fail security-audit on every PR. The vulnerable extract only runs on Windows, for a zip whose signature the updater has already verified, and Clavyn ships NSIS executables there.
PR Summary by QodoAdd dated audit suppressions for updater zip advisories
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #18.
Why
On 2026-10-09/10, RustSec published three advisories against
zip< 9: RUSTSEC-2026-0367 (SUID/SGID preserved on extract, 7.3), RUSTSEC-2026-0368 (symlinks pointing outside the destination) and RUSTSEC-2026-0369 (permissions applied through symlinks, 9.1).zip4.6.1 reaches the tree only throughtauri-plugin-updater. Since thencargo auditfailssecurity-auditon every PR, this one's base included.Why a suppression rather than an upgrade
tauri-plugin-updater2.13.0 and the newest 2.14.0 both declarezip = "4". There's nothing to bump to.zipfeature also gates thetar/flate2code that unpacks the macOS.app.tar.gzand AppImage updates. Disabling it would break updates on those platforms.ZipArchive::extractis called only on Windows, frominstall(). Clavyn callsdownload_and_install, wheredownload()verifies the minisign signature againstplugins.updater.pubkeybeforeinstall()runs. Clavyn's Windows updates are also NSIS executables, not zips. Reaching the vulnerable path takes an archive signed with the release key.Each entry carries a
review-by: 2026-12-31date.check-audit-expiry.mjspasses, and will fail CI on that date if the updater still pins zip 4.Verified
node scripts/verify/check-audit-expiry.mjs: ok, 4 entries dated.cargo auditagainst Consolidate the four open dependency bumps and clear the npm production audit #128'sCargo.lock, which fixes the open quinn-proto and rustls advisories, with thisaudit.toml: exit 0. Only the informationalproc-macro-errorandglibnotices remain, and CI runs those withcontinue-on-error.Merge order
Together with #128 this turns
security-auditgreen. Either can land first.Need help on this PR? Tag
@codesmith-botwith what you need.