Repository navigation
chore: bump @playcanvas/splat-transform to 3.10.3, playcanvas to 2.24.0 (+ 4 new flags wired) - #150
Open
CodeByKeegan wants to merge 4 commits into
Open
CodeByKeegan wants to merge 4 commits into
CodeByKeegan wants to merge 4 commits into
Conversation
Upstream 3.3.0 flipped the default decimation algorithm: plain --decimate is uniform/flat-rate again, and the adaptive (local-error) path moved to the new --decimate-adaptive flag; the old --decimate-uniform flag no longer exists. Rewires decimateFlag() in server/commands.mjs to match (adaptive -> --decimate-adaptive, uniform -> --decimate), keeping app UX/behavior unchanged since we already pass an explicit flag for the user's chosen algorithm either way. Updates every place that named the old flag: UI tooltips, the MCP tool descriptions, the e2e/mcp-e2e assertions, and the user guide. Also fixes a pre-existing typo in the MCP decimate description (wrong short flag) and refreshes the README version line (PlayCanvas was already at 2.21.4 in package.json but the README hadn't caught up) and the annotated UI screenshots. No other CLI surface changes between 3.2.0 and 3.3.3.
…ussians)
splat-transform 3.3.0 makes the LOD writer refuse any source containing a
non-finite gaussian ("LOD 0 gaussian N has a non-finite position; run
--filter-nan to drop invalid gaussians before writing LODs"), where 3.2.0
wrote the bundle. server/commands.mjs already emits -N after each input in
both LOD builders, but nothing could set it: filterNaN was exposed only on
the convert panel and the convert MCP tool, so a LOD bake had no in-flow
remedy for the error it was told to fix.
Add the Filter NaN checkbox to the LOD panel, send it from lod-panel.ts, and
declare filterNaN on the build_lod MCP schema. -N is an ordered action, so it
must follow its input — the e2e check asserts that placement alongside the
fail-then-succeed pair.
- fix --viewer-settings fixture + server preflight (3.5.0 validates settings) - default blank --scratch-dir to the project folder (3.6.0 dropped the implicit default) - wire --webp-effort, --lod-chunk-min, --lod-file-count, --dof-samples (UI, API, MCP, e2e) - pin --shutter to 1 so existing renders keep their blur (3.5.0 default is 0.5) - viewer: nullable MeshInstance#mesh; pin splat budget to LOD distances (2.23 default budget) - hide .decimate-gen spill files; ASCII PLY error text - README versions, USER_GUIDE/MCP docs, skills, screenshots refreshed Co-Authored-By: Claude <noreply@anthropic.com>
| const isObj = (v) => v != null && typeof v === 'object' && !Array.isArray(v); | ||
| const checkViewerSettings = (abs, rel) => { | ||
| let text; | ||
| try { text = readFileSync(abs, 'utf8'); } |
The docs capture harness looked for a "view" text button that no longer exists, so canonical screenshots never loaded the demo splat. Click the .file-eye button instead and re-capture. Co-Authored-By: Claude <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
@playcanvas/splat-transform3.2.0 → 3.10.3 andplaycanvas2.21.4 → 2.24.0.This PR covers everything in #98 (the 3.3.x decimate-flag rewire, kept as its own commit) and #92's LOD
--filter-nanfix (cherry-picked). It supersedes #142, #138, #98, #97, #92, #91, #90, #89, #83, #82 and #81.Fixes
--viewer-settingsis now validated upstream (3.5.0, #318). The e2e fixture is fixed. A server preflight now returns a 400 for a missing camera or background object, aversionother than absent or 2, a BOM, or invalid JSON.--scratch-dirno longer has a default (3.6.0, #324). Without one, deep decimations now fail. Splat Studio now defaults a blank value to the project folder, which matches 3.3.3's behaviour. This covers convert decimate and the LOD pre-commands. Leftover.decimate-gen*spill files are hidden from the Files panel.--shutteris pinned to 1. Upstream changed its default to 0.5 (3.5.0), and pinning keeps existing motion-blur renders unchanged.MeshInstance#meshis now nullable and is handled. The splat budget is pinned toGSPLAT_BUDGET_LIMIT/0, so LOD distance bands still decide what renders. The 2.23 default is a 1M-splat target budget.New flags wired
--webp-effortwebpEffortconvert/build_lod.webpEffort--lod-chunk-minlodChunkMin(default 8)build_lod.lodChunkMin--lod-file-countlodFileCountbuild_lod.lodFileCount--dof-samplesimage.dofSamplesrender_image.image.dofSamplesEach has a
title=tooltip naming the flag, form-state persistence,tests/e2e.mjschecks and MCP schema fields.--gpu-backendand--camera-track/--framesare deferred to issues (below).Release-notes review
splat-transform 3.3.3 → 3.10.3
--lod-chunk-min(default 8) means far fewer leaves for sparse, wide regions, so LOD output differs from 3.3.3 by design.--webp-effort.--shutterdefault 0.5. We pin 1.--dof-samples(default 32). Each sample is a full render, and the count multiplies with motion samples.--scratch-dirhas no implicit default (#324). Handled above.upvectors for camera tracks.--gpu-backend(#334). Deferred to Surface --gpu-backend (vulkan/d3d12) with backend-matched device lists #144.--lod-errorsand the LOD error metadata were removed (#339), so Surface per-leaf LOD approximation error (splat-transform 3.3.0) #80 is obsolete. The.splatwriter now normalizes rotations; we don't write.splat.--lod-file-count(#340). LOD writing is faster but uses more peak memory..sogabove 4 GiB (#352). Viewer guard in Guard zip64 .sog bundles (> 4 GiB) in the viewer #149.--statsmean and stdDev are now in display space. Our parser doesn't use them.-Non the LOD path: the writer still aborts on non-finite input.--lod-chunk-extent..ply.PlayCanvas 2.21.4 → 2.23.3
MeshInstance#meshis typed nullable.PlayCanvas 2.23.3 → 2.24.0 (added 2026-11-10; released 2026-11-09)
GSplatParams#antiAliasFilterSize, default 0.1, 3DGS 0.3 px² low-pass). The defaultminContributiondrops from 3 to 2. New loaders: SOG v3, SPZ v3 / LCC2, and SH band 4 for PLY. These are all engine defaults; the viewer pins only the splat budget mode, so it picks them up with no code change.castShadow,unpause,powerOfTwo,PIXELFORMAT_111110F,findAnimationLayer,enableShape,BoundingBox#intersects).TranslateGizmo,RotateGizmo, andGizmo.createLayerkeep their signatures.engine-internal:site against the 2.24.0 build._flyControllerand_mode(camera-controls), gsplat_centers, gizmo_hoverAxis, andAppBase.drawLineall still exist.Follow-up issues: #144 (
--gpu-backend), #145 (camera-track sequences), #146 (viewer-settings picker and job errors), #147 (LOD preview budget controls), #148 (engine-internals canary), #149 (zip64 SOG guard).Verification
npm run typecheck: clean.npm test: 78 passed, 0 failed with the GPU, and 72/72 withSKIP_GPU=1(CI-equivalent). Six new checks.npm run test:mcp: 26 passed, 0 failed, with two new checks.docs/USER_GUIDE.mdanddocs/MCP_WORKFLOWS.md..agents/re-synced.npm run docs:capture.lod-decimate.pngthe new Min split / File size row is a native.field-rowpair under Chunk size / Chunk extent, and the Maximum compression checkbox sits under the encoder row.render-tab.pngshows Blur quality under the DoF pair.npm test78/78 with the GPU.npm run test:mcp26/26.npm run docs:capturere-captured all 24 screenshots..file-eye. The re-captured shots show the demo splat rendering on 2.24.0, with the translate gizmo drawing correctly (viewport-toolbar.png,camera-view.png). This is why every screenshot changed in this commit.Authored autonomously by the weekly dependency-update routine.
🤖 Generated with Claude Code