London | 26 - JUL-SDC| Ping Wang |Sprint 5 |Spring 5 exercises-CYF 1155 - #647
London | 26 - JUL-SDC| Ping Wang |Sprint 5 |Spring 5 exercises-CYF 1155#647pathywang wants to merge 14 commits into
Conversation
pathywang
added
the
Needs Review
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good start on these tasks. There are some issues to work on.
Be careful of your spelling here, there are a few issues, can you resolve them?
There was a problem hiding this comment.
Can you add explicit type annotations here?
There was a problem hiding this comment.
thanks i add type annotations when i define function
| ] | ||
|
|
||
| for person in people: | ||
| possible_laptops = find_possible_laptops(laptops, person) |
There was a problem hiding this comment.
When I run this, the suggested laptops are empty? Do you also see this?
There was a problem hiding this comment.
yes i do because operating_system is a list but person.preferred_operating_system is a string, so i amend person preferred operation system to list. thanks
| try: | ||
| preferred_os = OperatingSystem(os_input) | ||
| except ValueError: | ||
| print("Error: invalid operating system.", file=sys.stderr) |
There was a problem hiding this comment.
Can you think of a more ux-friendly way of validating this input?
There was a problem hiding this comment.
thanks, i amend the code which keeps asking until the user enters a valid option instead of existing.
LonMcGregor
added
Reviewed
|
Thank you for checking for me. I amend the code as required and check my spelling as well. |
pathywang
added
Needs Review
2 participants
Self checklist
Changelist
did prep then make new directory and new branch for this coursework