Use release ndlls instead of the debug ones for debug builds and a proper Mac OS Universal support - #1052
Use release ndlls instead of the debug ones for debug builds and a proper Mac OS Universal support#1052MRK2009 wants to merge 3 commits into
release ndlls instead of the debug ones for debug builds and a proper Mac OS Universal support#1052Conversation
|
Looking at the commit history and the other pull requests, it's probably defaulting to |
|
Where does it do this in hxvlc? i think i'm against this? |
|
Please don't redo the prs, i can rebase the prs myself |
114f958 to
2e4caef
Compare
|
Okay I'll wait. |
Idk, I read the docs anyway, just for a little clean-up to be more safe. |
|
Also I didn't mean to press ready for review, I didn't realise ofc. |
I'm too lazy to make a branch, that's the problem. |
|
You could just make the changes in main and then switch the pr base branch to internal-merge theorically if it doesn't have any conflicts |
Maybe I'll do that I guess. |
Wait I don't think I need your help anymore, I found the right command to fix it, give me some minutes. |
|
LET'S GOOOOO!!!!!!! IT WORKED!!! |
3447b60 to
35351b3
Compare
video type from var to finalrelease ndlls instead of the debug ones for debug builds and a proper Mac OS Universal support
cb39da8 to
b3a48ca
Compare
|
Yk what, f#ck it, I made my pr become better than before. |
b64cf8a to
e402aef
Compare
8512641 to
036fe76
Compare
163fd34 to
310ef3e
Compare
310ef3e to
72f8152
Compare
Redo of #1051 and #1049
Oh please no, don't waste my time for nothing without knowing how to fix my pr.
I'm begging you please.
New description:
Switched the ndlls from debug to release for debug builds, since it's trying to load the ndlls internally for the lime tools. I tested the debug build on Windows and it still looks okay.
I thought my pr #931 gonna bring Universal support for Mac, but I was wrong, instead it targets ARM, so the only way to bring Universal support for it is to build both Intel and ARM separately and then merge them together.