Repository navigation
Auto memory import says memories, lists a line per folder, and passes over .DS_Store - #106
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #101 (import-paths), which rewrote the same file. Merge #101 first; this PR then retargets to main.
Fixes runningbugs #377 and part of #330:
TestAnEmptyAutoMemoryImportSaysMemoriesNotMemorys..DS_Store) is no longer reported as "Left out … not a note" on every run. A hidden.mdis still read, and any other visible file is still reported. Test:TestHiddenFilesInTheAutoMemoryFolderAreNotReportedAsLeftOut.… /memory 3 memories, for project shop). Rules files still get a line per file. Test:TestAutoMemoryIsFoundAsOneLinePerFolderAndScope.Left out on purpose: keeping a note's frontmatter
descriptionalongside its body (the third half of #330). 0.5.5 and 0.5.6 already queued body-only text. Changing the text would re-offer every note a user had accepted or rejected. Matching on the old text instead would leave existing imports body-only for good, and would also match the same sentence from other sources. Doing it properly means rewriting held rows, vault first. That is its own change.Verified:
go build,go vet,gofmt -l: clean.go test ./...: ok.go test -tags chaos ./chaos/...: ok.check-bug-tests,check-commits,check-test-namesagainst import-paths: ok. Each new test fails on the base.import --from claude-auto-memory --dry-runin a scratch HOME with three notes and a.DS_Store: the old binary printed the.DS_Storeline and three "1 memory" rows; the new one prints one row, "3 memories".