Repository navigation
An unread memory file keeps its unflushed flag, is never overwritten, and is named when the index refuses - #111
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #109. Three holes in its #369 fix, found by review of #110, which this replaces:
keep, so the index cleared that row's unflushed flag. Nothing confirmed the memory was in the vault. The row is still kept from the reap, but its flag now stays set, for doctor and the next index.writeMemoryFileran its hand-edit check only if the file could be read. When it couldn't, the write went over whatever a person had put there. It now refuses and says why.Each test fails on #109's code (
scripts/check-bug-tests.sh origin/bugfix-0.5.7-open-bugs-v2 HEAD).