Skip to content

test: isolate persisted violation traces from committed examples #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CodewithJha merged 1 commit into from
Sep 24, 2026
Merged

test: isolate persisted violation traces from committed examples #85

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions tests/unit/test_m4_violation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@

ROOT = Path(__file__).resolve().parents[2]
DEMO_POLICY = ROOT / "examples" / "policies" / "demo_support.json"
TRACE_OUT = ROOT / "examples" / "traces" / "m4_refund_limit_violation.json"


def _policy() -> PolicySet:
Expand Down Expand Up @@ -121,8 +120,8 @@ def test_mutation_path_finds_violation_from_sub_boundary_seeds():
assert refunds[-1].arguments["approved"] is not True


def test_persist_violation_trace_artifact():
"""Write a real violating trace for inspection (M4 DoD)."""
def test_persist_violation_trace_artifact(tmp_path: Path):
"""Round-trip a violating trace without rewriting the committed example."""
engine = CampaignEngine(
adapter=InProcessDemoAdapter(),
policy_set=_policy(),
Expand All @@ -148,8 +147,10 @@ def test_persist_violation_trace_artifact():
"tool_calls": [tc.model_dump() for tc in winner.trace.all_tool_calls],
"policy_hits": [h.model_dump() for h in winner.hits],
}
TRACE_OUT.parent.mkdir(parents=True, exist_ok=True)
TRACE_OUT.write_text(json.dumps(artifact, indent=2))
assert TRACE_OUT.exists()
loaded = json.loads(TRACE_OUT.read_text())
trace_out = tmp_path / "m4_refund_limit_violation.json"
trace_out.write_text(json.dumps(artifact, indent=2))
assert trace_out.is_file()
loaded = json.loads(trace_out.read_text())
assert loaded == artifact
assert any(tc["name"] == "issue_refund" for tc in loaded["tool_calls"])
assert any(h["rule_id"] == "refund_limit" and h["violated"] for h in loaded["policy_hits"])
Loading