Skip to content

fix: ignore generated artifacts in the sample .mutiny directory - #86

Merged
CodewithJha merged 1 commit into
CodewithJha:mainfrom
fatihcvs:fix/sample-generated-ignores
Sep 24, 2026
Merged

CodewithJha merged 1 commit into
CodewithJha:mainfrom
fatihcvs:fix/sample-generated-ignores

Conversation

@fatihcvs

Copy link
Copy Markdown
Contributor

Summary

Fixes #73. Replace the recursive un-ignore of the sample .mutiny directory with an explicit allowlist for adapter.py and init.py. Bytecode and generated campaign regressions remain ignored; the shipped adapter sources remain tracked.

Type of change

  • Bug fix
  • CLI / DX

Checklist

  • Read CONTRIBUTING.md
  • Linked the related issue
  • No Core/framework boundary changes
  • Checked behavior with Git and a real offline sample run; full unit suite run
  • No unsupported documentation claims
  • One concern per PR
  • Authorized local testing only

Test plan

  • Before the change, git check-ignore -v showed the recursive negation matching both bytecode and generated JSON, and pycache appeared in git status.
  • Ran the sample's mutiny run with MUTINY_SAMPLE_OFFLINE=1 and model keys unset. It completed a local campaign and wrote .mutiny/tests/cli_discovered_violation.json.
  • git check-ignore -v --no-index now confirms bytecode and generated JSON are ignored, while the two source files match explicit negations. git ls-files --error-unmatch confirms both remain tracked. The sample tree stays clean in git status.
  • pytest tests/unit -q --tb=short: 376 passed on Python 3.12.14. The existing tracked-trace side effect was reverted after testing; test: isolate persisted violation traces from committed examples #85 addresses that separately.
  • git diff --check passed.

Independent branch from main; includes neither #83 nor #85.

@vercel

vercel Bot commented Sep 24, 2026

Copy link
Copy Markdown

@fatihcvs is attempting to deploy a commit to the priyanshu's projects Team on Vercel.

A member of the Team first needs to authorize it.

@CodewithJha CodewithJha left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fatihcvs — this hits #73 / MUT-025 cleanly: sample .mutiny/ now un-ignores only __init__.py and adapter.py, so __pycache__ and generated tests stay ignored. Tracked adapter files remain. GitHub Actions green on 3.11/3.12; ignoring Vercel auth.

@CodewithJha
CodewithJha merged commit 06345e2 into CodewithJha:main Sep 24, 2026
5 of 6 checks passed
@CodewithJha

Copy link
Copy Markdown
Owner

Merged — thank you @fatihcvs. Exactly the kind of contributor-workflow hygiene Mutiny needs: sample adapter.py stays tracked, generated __pycache__ and campaign tests stay out of git status.

If you'd like to continue working on Mutiny, these would be good related areas to look at:

  • #62 — leftover Hosted project_path exec copy after the observe-only pivot
  • #77 — docs lag vs 0.2.0 / observe-only Hosted
  • #76 — Python CI is pytest-only (no ruff gate); small CI/DX follow-up

No pressure — only if you want another one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DX] MUT-025: Sample .mutiny gitignore un-ignores __pycache__

2 participants