-
Notifications
You must be signed in to change notification settings - Fork 1
fix: OAuth2 token encoding and /auth/info route #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Coding-Dev-Tools
wants to merge
8
commits into
master
Choose a base branch
from
cowork/improve-envault
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
4a882b5
cowork-bot: fix dead code in serve.py, add /auth/info route and tests
2185149
cowork-bot: fix dead code in serve.py, add /auth/info route and tests
f1547b1
cowork-bot: encode OAuth2 introspection tokens
Coding-Dev-Tools 526553d
cowork-bot: URL-encode 1Password Connect filter keys to handle specia…
Coding-Dev-Tools 343b88f
cowork-bot: apply ruff format to test files per automated code review
Coding-Dev-Tools 0831ab7
cowork-bot: fix backup manifest loading to skip corrupt entries inste…
Coding-Dev-Tools 9e3d19c
cowork-bot: add 44 regression tests for auth module coverage gaps
Coding-Dev-Tools 3306569
cowork-bot: fix ruff I001 import sorting in test_auth_coverage.py per…
Coding-Dev-Tools File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| from __future__ import annotations | ||
|
|
||
| import json | ||
|
|
||
| from envault.auth import OAuth2Auth | ||
|
|
||
|
|
||
| def test_oauth2_introspection_url_encodes_reserved_token_characters(monkeypatch): | ||
| captured: dict[str, object] = {} | ||
|
|
||
| class _Response: | ||
| status = 200 | ||
|
|
||
| def __enter__(self): | ||
| return self | ||
|
|
||
| def __exit__(self, exc_type, exc_value, traceback): | ||
| return False | ||
|
|
||
| def read(self): | ||
| return json.dumps({"active": True, "sub": "synthetic-user"}).encode() | ||
|
|
||
| def fake_urlopen(request, timeout): | ||
| captured["request"] = request | ||
| captured["timeout"] = timeout | ||
| return _Response() | ||
|
|
||
| monkeypatch.setattr("envault.auth.urlopen", fake_urlopen) | ||
|
|
||
| result = OAuth2Auth(provider_url="https://identity.example", strategy="introspect").check( | ||
| {"Authorization": "Bearer token+with&reserved=value"} | ||
| ) | ||
|
|
||
| assert result.success | ||
| request = captured["request"] | ||
| assert request.data == b"token=token%2Bwith%26reserved%3Dvalue" | ||
| assert captured["timeout"] == 10 |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.