Skip to content

EDGE: Harden PSBTv2 parsing and preserve Miniscript context - #817

Open
scgbckbone wants to merge 1 commit into
Coldcard:new_edgefrom
scgbckbone:fix/embit-psbt-miniscript-hardening
Open

scgbckbone wants to merge 1 commit into
Coldcard:new_edgefrom
scgbckbone:fix/embit-psbt-miniscript-hardening

Conversation

@scgbckbone

Copy link
Copy Markdown
Collaborator

Summary

  • reject key data on BIP370 singleton fields in global, input, and output maps
  • require an explicit global version for PSBTv2 and reject non-exact global CompactSize counts
  • preserve the Taproot context when deriving Miniscript nodes
  • add focused parser and Miniscript regression coverage

Comment thread releases/EdgeChangeLog.md

# Shared Improvements - Both Mk4 and Q

- Enhancement: Support per-input required height and time locktimes in PSBTv2 transactions.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is from PR #816 where I forgot to add edge changelog entry

@scgbckbone
scgbckbone force-pushed the fix/embit-psbt-miniscript-hardening branch from 01540e1 to 26a3362 Compare September 11, 2026 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant